[jira] [Updated] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately

["Erick Erickson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-13952:
----------------------------------
    Attachment: fordavid.patch
        Status: Open  (was: Open)

[~dsmiley] The "fordavid.patch" contains the changes Mark made to XmlOffsetCorrector.java in the gradle_8 build. Do you have an opinion about whether these are valid/dangerous/need-to-be-tested/etc.?

IOW should I revert this change or just commit to master when the time comes?

Thanks

> Separate out Gradle-specific code from other (mostly test) changes and commit separately
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13952
>                 URL: https://issues.apache.org/jira/browse/SOLR-13952
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much easier to work on the gradle parts if these were separated. So here's my plan:
> - establish a branch to use for the non-gradle parts of the gradle_8 branch and commit separately. For a first cut, I'll make all the changes I'm confident of, and mark the others with nocommits so we can iterate and decide when to merge to master and 8x.
> - create a "gradle_9" branch that hosts only the gradle changes for us all to iterate on.
> I hope to have a preliminary cut at this over the weekend. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org