You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/02 16:41:32 UTC
(commons-compress) 02/03: Better parameter names
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 9267e73a62ab6df10592d1bce70fc5c3c1f088e4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Nov 2 12:30:44 2023 -0400
Better parameter names
---
.../apache/commons/compress/archivers/Lister.java | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/main/java/org/apache/commons/compress/archivers/Lister.java b/src/main/java/org/apache/commons/compress/archivers/Lister.java
index 7e358e71..fb88da40 100644
--- a/src/main/java/org/apache/commons/compress/archivers/Lister.java
+++ b/src/main/java/org/apache/commons/compress/archivers/Lister.java
@@ -42,16 +42,16 @@ public final class Lister {
private static final ArchiveStreamFactory FACTORY = ArchiveStreamFactory.DEFAULT;
- private static ArchiveInputStream createArchiveInputStream(final String[] args, final InputStream fis)
+ private static ArchiveInputStream createArchiveInputStream(final String[] args, final InputStream inputStream)
throws ArchiveException {
if (args.length > 1) {
- return FACTORY.createArchiveInputStream(args[1], fis);
+ return FACTORY.createArchiveInputStream(args[1], inputStream);
}
- return FACTORY.createArchiveInputStream(fis);
+ return FACTORY.createArchiveInputStream(inputStream);
}
- private static String detectFormat(final File f) throws ArchiveException, IOException {
- try (final InputStream fis = new BufferedInputStream(Files.newInputStream(f.toPath()))) {
+ private static String detectFormat(final File file) throws ArchiveException, IOException {
+ try (final InputStream fis = new BufferedInputStream(Files.newInputStream(file.toPath()))) {
return ArchiveStreamFactory.detect(fis);
}
}
@@ -68,8 +68,8 @@ public final class Lister {
}
}
- private static void listStream(final File f, final String[] args) throws ArchiveException, IOException {
- try (final InputStream fis = new BufferedInputStream(Files.newInputStream(f.toPath()));
+ private static void listStream(final File file, final String[] args) throws ArchiveException, IOException {
+ try (final InputStream fis = new BufferedInputStream(Files.newInputStream(file.toPath()));
final ArchiveInputStream ais = createArchiveInputStream(args, fis)) {
System.out.println("Created " + ais.toString());
ArchiveEntry ae;
@@ -79,15 +79,15 @@ public final class Lister {
}
}
- private static void listZipUsingTarFile(final File f) throws IOException {
- try (TarFile t = new TarFile(f)) {
+ private static void listZipUsingTarFile(final File file) throws IOException {
+ try (TarFile t = new TarFile(file)) {
System.out.println("Created " + t);
t.getEntries().forEach(en -> System.out.println(en.getName()));
}
}
- private static void listZipUsingZipFile(final File f) throws IOException {
- try (ZipFile z = new ZipFile(f)) {
+ private static void listZipUsingZipFile(final File file) throws IOException {
+ try (ZipFile z = new ZipFile(file)) {
System.out.println("Created " + z);
for (final Enumeration<ZipArchiveEntry> en = z.getEntries(); en.hasMoreElements(); ) {
System.out.println(en.nextElement().getName());