You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jacek Lewandowski (Jira)" <ji...@apache.org> on 2022/09/14 10:00:01 UTC
[jira] [Comment Edited] (CASSANDRA-17783) Move {{Schema.FORCE_LOAD_KEYSPACES}} and {{Schema.FORCE_LOAD_KEYSPACES_PROP}} to {{CassandraRelevantProps}}
[ https://issues.apache.org/jira/browse/CASSANDRA-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603997#comment-17603997 ]
Jacek Lewandowski edited comment on CASSANDRA-17783 at 9/14/22 9:59 AM:
------------------------------------------------------------------------
[~drohrer] I think that your change makes sense for 4.1 and for trunk. Why don't you create PRs for 4.1 and trunk from your fork. For CI, it makes sense to keep the config changes in a separate commit. I don't really know how to review a patch file
was (Author: jlewandowski):
[~drohrer] I think that change makes sense for 4.1 and for trunk. Why don't you create PRs for 4.1 and trunk from your fork. For CI, it makes sense to keep the config changes in a separate commit. I don't really know how to review a patch file
> Move {{Schema.FORCE_LOAD_KEYSPACES}} and {{Schema.FORCE_LOAD_KEYSPACES_PROP}} to {{CassandraRelevantProps}}
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17783
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
> Reporter: Doug Rohrer
> Assignee: Doug Rohrer
> Priority: Low
> Fix For: 4.x
>
> Attachments: CASSANDRA-17783-rebased.patch
>
>
> {{Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP}} and {{Schema.FORCE_LOAD_LOCAL_KEYSPACES}} should be moved to {{CassandraRelevantProps}} for two reasons.
> # Generally speaking, this is where these kinds of things live.
> # By having them in Schema, you can't actually use {{Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP}} without running all of the static initializers... and you want to use {{Schema.FORCE_LOAD_LOCAL_KEYSPACES_PROP}} to set the system property before the static initializer runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org