You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pranay Pandey (JIRA)" <ji...@apache.org> on 2009/03/02 10:22:12 UTC
[jira] Created: (OFBIZ-2223) User can select options for preparing
a group on the basis of Shipping method, Warehouse area and Number of order
items (one to two, three or more). So that group of Orders are created
according to selected options.
User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-2223
URL: https://issues.apache.org/jira/browse/OFBIZ-2223
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: SVN trunk
Reporter: Pranay Pandey
Fix For: SVN trunk
When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
*Implementations Notes:*
* Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
* Select factors to group by, using one checkbox for each:
*# Number of order items (one to two, three or more).
*# Warehouse area.
*# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2223) User can select options for preparing
a group on the basis of Shipping method, Warehouse area and Number of order
items (one to two, three or more). So that group of Orders are created
according to selected options.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-2223:
--------------------------------
Attachment: OFBIZ-2223.patch
Thanks Vikas for your suggestions . I have uploaded the patch with all the suggestions
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch, OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2223) User can select options for preparing a
group on the basis of Shipping method, Warehouse area and Number of order
items (one to two, three or more). So that group of Orders are created
according to selected options.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur closed OFBIZ-2223.
------------------------------
Resolution: Fixed
Thanks Arun!
Your patch is trunk rev. 762399.
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch, OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2223) User can select options for preparing
a group on the basis of Shipping method, Warehouse area and Number of order
items (one to two, three or more). So that group of Orders are created
according to selected options.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-2223:
--------------------------------
Attachment: OFBIZ-2223.patch
Here is a patch for following functionality:
User can select options to group by order ready to pick on the basis of shipping method, warehouse area, number of order items (one to two, three or more).
Review list of groups of orders ready to pick.
Steps to test the functionality:
1) Create three or more sales order with different shipping method and no. of order items.
2) Go to picking tab in facility .
3) Select options to group order ready to pick.
4) There will be one list item for each combination of options from each of the factors selected (for example if there are 4 shipping methods and 2 options for number of order items, there will be 2x4=8 rows in the list).
5) On depressing the particular group , See the number of orders ready to pick for each combination.
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2223) User can select options for preparing
a group on the basis of Shipping method, Warehouse area and Number of order
items (one to two, three or more). So that group of Orders are created
according to selected options.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2223:
----------------------------------
Assignee: Vikas Mayur
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2223) User can select options for
preparing a group on the basis of Shipping method, Warehouse area and
Number of order items (one to two, three or more). So that group of Orders
are created according to selected options.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695886#action_12695886 ]
Vikas Mayur commented on OFBIZ-2223:
------------------------------------
Hi Arun, This is just for your future patches, please do not try to touch those lines that are not necessary to be changed. One example that I find is
{code}
- <set from-field="parameters.orderHeaderList" field="orderHeaderList"/>
+ <set field="orderHeaderList" from-field="parameters.orderHeaderList"/>
{code}
This is a no change in above code other then the ordering of the fields and generally should be avoided.
Thanks,
Vikas
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2223) User can select options
for preparing a group on the basis of Shipping method, Warehouse area and
Number of order items (one to two, three or more). So that group of Orders
are created according to selected options.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695886#action_12695886 ]
Vikas Mayur edited comment on OFBIZ-2223 at 4/5/09 11:22 AM:
-------------------------------------------------------------
Hi Arun, This is just for your future patches, please do not try to touch those lines that are not necessary to be changed. One example that I find is
{code}
- <set from-field="parameters.orderHeaderList" field="orderHeaderList"/>
+ <set field="orderHeaderList" from-field="parameters.orderHeaderList"/>
{code}
Their is a no change in above code other then the ordering of the fields and generally should be avoided.
Thanks,
Vikas
was (Author: vikasmayur):
Hi Arun, This is just for your future patches, please do not try to touch those lines that are not necessary to be changed. One example that I find is
{code}
- <set from-field="parameters.orderHeaderList" field="orderHeaderList"/>
+ <set field="orderHeaderList" from-field="parameters.orderHeaderList"/>
{code}
This is a no change in above code other then the ordering of the fields and generally should be avoided.
Thanks,
Vikas
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2223) User can select options
for preparing a group on the basis of Shipping method, Warehouse area and
Number of order items (one to two, three or more). So that group of Orders
are created according to selected options.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695038#action_12695038 ]
Arun Patidar edited comment on OFBIZ-2223 at 4/2/09 9:42 PM:
-------------------------------------------------------------
Here is a patch for this issue:
User can select options to group by order ready to pick on the basis of shipping method, warehouse area, number of order items (one to two, three or more).
Review list of groups of orders ready to pick.
Steps to test the functionality:
# Create three or more sales order with different shipping method and no. of order items.
# Go to picking tab in facility .
# Select options to group order ready to pick and submit.
# You will get the list of groups based on the factors selected to group by user.
# On depressing the particular group, you will see the no. of order belonging to that group.
was (Author: arunpati):
Here is a patch for following functionality:
User can select options to group by order ready to pick on the basis of shipping method, warehouse area, number of order items (one to two, three or more).
Review list of groups of orders ready to pick.
Steps to test the functionality:
1) Create three or more sales order with different shipping method and no. of order items.
2) Go to picking tab in facility .
3) Select options to group order ready to pick.
4) There will be one list item for each combination of options from each of the factors selected (for example if there are 4 shipping methods and 2 options for number of order items, there will be 2x4=8 rows in the list).
5) On depressing the particular group , See the number of orders ready to pick for each combination.
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2223) User can select options for
preparing a group on the basis of Shipping method, Warehouse area and
Number of order items (one to two, three or more). So that group of Orders
are created according to selected options.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695874#action_12695874 ]
Vikas Mayur commented on OFBIZ-2223:
------------------------------------
Hi Arun, Patch looks good. Few changes that I would suggest (and would like you to test with those changes :)) are
1) I think this can be replaced (or probably similar occurrence)
{code}
<!-- adds location of item in location list uniquely -->
<if-compare field="groupByWarehouseArea" operator="equals" value="Y">
<set field="addInList" value="Y"/>
<if-not-empty field="locations">
<iterate list="locations" entry="location">
<if-compare-field field="location" operator="equals" to-field="locationGroupName">
<set field="addInList" value="N"/>
</if-compare-field>
</iterate>
</if-not-empty>
<if-compare field="addInList" operator="equals" value="Y">
<field-to-list field="locationGroupName" list="locations"/>
</if-compare>
<clear-field field="addInList"/>
</if-compare>
{code}
with
{code}
<!-- adds location of item in location list uniquely -->
<if-compare field="groupByWarehouseArea" operator="equals" value="Y">
<if>
<condition><not><if-compare-field field="locations" operator="contains" to-field="locationGroupName"/></not></condition>
<then><field-to-list field="locationGroupName" list="locations"/></then>
</if>
</if-compare>
{code}
2) Try to use from-field instead of value in following case.
{code}
<if-compare field="groupByWarehouseArea" operator="equals" value="Y">
<set field="groupName2" value="${OrderItemAndFacilityLocation.areaId}"/>
<set field="locationGroupName" value="${OrderItemAndFacilityLocation.areaId}"/>
</if-compare>
{code}
I think #1 would result in less number of code and would increase the clarity of the code as well.
Thanks,
Vikas
> User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to selected options.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2223
> URL: https://issues.apache.org/jira/browse/OFBIZ-2223
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2223.patch
>
>
> When order is ready to pick (ie in approved status), User go to Facility-->Picking, then group is already prepared on the basis of shipping method (for creating picklist) . We should have functionality where User can select options for preparing a group on the basis of Shipping method, Warehouse area and Number of order items (one to two, three or more). So that group of Orders are created according to the selected options. Pick list create functionality will be working as it is.
> *Implementations Notes:*
> * Go to Facility -> Picking tab or page https://localhost:8443/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> * Select factors to group by, using one checkbox for each:
> *# Number of order items (one to two, three or more).
> *# Warehouse area.
> *# Shipping method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.