You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2021/06/09 22:49:04 UTC
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17572
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Testcases are added for some abnormal cases of spill to a remote fs,
such as errors happen during spilling to a remote fs, or configured
a non-existent remote scratch path.
Added two unit tests in TmpFileMgrTest,
TestRemoteUploadToNonExistentPath and TestRemoteUploadFailed.
Testing:
* ran core tests
* passed new testcases
Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
---
M be/src/runtime/io/disk-file.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
3 files changed, 100 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/17572/1
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8873/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 23:11:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 18:28:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Testcases are added for some abnormal cases of spill to a remote fs,
such as errors happen during spilling to a remote fs, or configured
a non-existent remote scratch path.
Added two unit tests in TmpFileMgrTest,
TestRemoteUploadToNonExistentPath and TestRemoteUploadFailed.
Testing:
* ran core tests
* passed new testcases
Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Reviewed-on: http://gerrit.cloudera.org:8080/17572
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/io/disk-file.h
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
4 files changed, 126 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h
File be/src/runtime/io/disk-file.h:
http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h@154
PS1, Line 154:
> Is there no other way to specify an invalid path? Is the issue that we will
Done, construct new TmpFile objects with an invalid path to create the error.
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Jun 2021 17:59:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
LGTM, Just had one comment about making a const variable non-const.
http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h
File be/src/runtime/io/disk-file.h:
http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h@154
PS1, Line 154:
Is there no other way to specify an invalid path? Is the issue that we will fail too early for the testcase, if we specify an invalid path in the constructor?
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 21:44:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7251/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 04:09:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 10:11:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8935/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Jun 2021 06:19:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Testcases are added for some abnormal cases of spill to a remote fs,
such as errors happen during spilling to a remote fs, or configured
a non-existent remote scratch path.
Added two unit tests in TmpFileMgrTest,
TestRemoteUploadToNonExistentPath and TestRemoteUploadFailed.
Testing:
* ran core tests
* passed new testcases
Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
---
M be/src/runtime/io/disk-file.h
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
4 files changed, 120 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/17572/2
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8907/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Jun 2021 18:17:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Testcases are added for some abnormal cases of spill to a remote fs,
such as errors happen during spilling to a remote fs, or configured
a non-existent remote scratch path.
Added two unit tests in TmpFileMgrTest,
TestRemoteUploadToNonExistentPath and TestRemoteUploadFailed.
Testing:
* ran core tests
* passed new testcases
Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
---
M be/src/runtime/io/disk-file.h
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
4 files changed, 126 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/17572/3
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef
Gerrit-Change-Number: 17572
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 04:09:46 +0000
Gerrit-HasComments: No