[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11684: WIP(axisPointer): snapping logic WIP.

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #11684: WIP(axisPointer): snapping logic WIP.
URL: https://github.com/apache/incubator-echarts/pull/11684#discussion_r351065548
 
 

 ##########
 File path: src/component/axisPointer/axisTrigger.js
 ##########
 @@ -97,19 +97,92 @@ export default function (payload, ecModel, api) {
 
     // Process for triggered axes.
     each(coordSysAxesInfo.coordSysMap, function (coordSys, coordSysKey) {
+        /**
+         * If both x and y axes are snapping and one and only one of them is
+         * of category type, then the category axis is used as primary
+         * snapping, otherwise the baseAxis is used as primary snapping.
+         * The snapped value of the other axis is calculated from it.
+         *
 
 Review comment:
   `'time'` is the same as `'value'`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org