You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/15 09:15:14 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new issue, #969: CI: Encapsulate functions to reuse code

tao12345666333 opened a new issue, #969:
URL: https://github.com/apache/apisix-ingress-controller/issues/969

   I think we can encapsulate a method `ensureAdminOperationIsSuccessful`, and pass the request, so that we can reuse the code base of `ensureHTTPPutSuccess`.
   
   _Originally posted by @tokers in https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r844945283_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] cmssczy commented on issue #969: CI: Encapsulate functions to reuse code

Posted by GitBox <gi...@apache.org>.
cmssczy commented on issue #969:
URL: https://github.com/apache/apisix-ingress-controller/issues/969#issuecomment-1100040231

   ok, pls assign to me.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #969: CI: Encapsulate functions to reuse code

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #969:
URL: https://github.com/apache/apisix-ingress-controller/issues/969#issuecomment-1102000325

   #971 fixed this one 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #969: CI: Encapsulate functions to reuse code

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #969:
URL: https://github.com/apache/apisix-ingress-controller/issues/969#issuecomment-1100056517

   Assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #969: CI: Encapsulate functions to reuse code

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #969:
URL: https://github.com/apache/apisix-ingress-controller/issues/969#issuecomment-1099987743

   @cmssczy Are you interested in this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #969: CI: Encapsulate functions to reuse code

Posted by GitBox <gi...@apache.org>.
tao12345666333 closed issue #969: CI: Encapsulate functions to reuse code
URL: https://github.com/apache/apisix-ingress-controller/issues/969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org