You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/03/17 19:46:53 UTC
[GitHub] [shiro] pitjazz opened a new pull request #287: Fixed a bug, removed the boxing to long.
pitjazz opened a new pull request #287:
URL: https://github.com/apache/shiro/pull/287
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] pitjazz commented on a change in pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
pitjazz commented on a change in pull request #287:
URL: https://github.com/apache/shiro/pull/287#discussion_r599077631
##########
File path: web/src/main/java/org/apache/shiro/web/session/HttpServletSession.java
##########
@@ -83,7 +83,8 @@ public long getTimeout() throws InvalidSessionException {
public void setTimeout(long maxIdleTimeInMillis) throws InvalidSessionException {
try {
- int timeout = Long.valueOf(maxIdleTimeInMillis / 1000).intValue();
+ long ltimeout = maxIdleTimeInMillis / 1000;
+ int timeout = (int)ltimeout;
Review comment:
Thank you, I understand. Changed the commit message to suggested one. Squashed the commits to one commit.
Please review @bdemers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] pitjazz commented on pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
pitjazz commented on pull request #287:
URL: https://github.com/apache/shiro/pull/287#issuecomment-801377359
Removed a bug which was described in SonarCloud: [link to bug](https://sonarcloud.io/project/issues?id=apache_shiro&languages=java&open=AXTvO9sg3S_U1xqKcOjR&resolved=false&severities=MINOR&types=BUG).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon merged pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
fpapon merged pull request #287:
URL: https://github.com/apache/shiro/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] pitjazz commented on a change in pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
pitjazz commented on a change in pull request #287:
URL: https://github.com/apache/shiro/pull/287#discussion_r599036088
##########
File path: web/src/main/java/org/apache/shiro/web/session/HttpServletSession.java
##########
@@ -83,7 +83,8 @@ public long getTimeout() throws InvalidSessionException {
public void setTimeout(long maxIdleTimeInMillis) throws InvalidSessionException {
try {
- int timeout = Long.valueOf(maxIdleTimeInMillis / 1000).intValue();
+ long ltimeout = maxIdleTimeInMillis / 1000;
+ int timeout = (int)ltimeout;
Review comment:
SonarCloud link for this bug/cleanup: [here](https://sonarcloud.io/project/issues?id=apache_shiro&languages=java&open=AXTvO9sg3S_U1xqKcOjR&resolved=false&severities=MINOR&types=BUG).
I'll clean the commit message etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #287:
URL: https://github.com/apache/shiro/pull/287#issuecomment-819639823
@bdemers I think we are good now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on a change in pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #287:
URL: https://github.com/apache/shiro/pull/287#discussion_r599045733
##########
File path: web/src/main/java/org/apache/shiro/web/session/HttpServletSession.java
##########
@@ -83,7 +83,8 @@ public long getTimeout() throws InvalidSessionException {
public void setTimeout(long maxIdleTimeInMillis) throws InvalidSessionException {
try {
- int timeout = Long.valueOf(maxIdleTimeInMillis / 1000).intValue();
+ long ltimeout = maxIdleTimeInMillis / 1000;
+ int timeout = (int)ltimeout;
Review comment:
I appreciate the SonarCloud link, but we need to embed the info in the commit message (the SonarCloud content could be removed at some point in the future, so we would need to provide the same context in the commit message directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on a change in pull request #287: Fixed a bug, removed the boxing to long.
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #287:
URL: https://github.com/apache/shiro/pull/287#discussion_r599032232
##########
File path: web/src/main/java/org/apache/shiro/web/session/HttpServletSession.java
##########
@@ -83,7 +83,8 @@ public long getTimeout() throws InvalidSessionException {
public void setTimeout(long maxIdleTimeInMillis) throws InvalidSessionException {
try {
- int timeout = Long.valueOf(maxIdleTimeInMillis / 1000).intValue();
+ long ltimeout = maxIdleTimeInMillis / 1000;
+ int timeout = (int)ltimeout;
Review comment:
Thanks @pitjazz
This could probably just be something like:
```java
int timeout = (int) (maxIdleTimeInMillis / 1000);
```
Can also clean up the commit and PR comment. This isn't really a "bug" it's more code cleanup, maybe something like:
> Removed unnecessary boxing in HttpServletSession
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org