You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2013/08/07 00:37:49 UTC
Review Request 13364: [HELIX-147] Fix typo in Idealstate property
max_partitions_per_instance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13364/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
Description
-------
Fix typo in Idealstate property max_partitions_per_instance
Diffs
-----
Diff: https://reviews.apache.org/r/13364/diff/
Testing
-------
File Attachments
----------------
https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff
Thanks,
Zhen Zhang
Re: Review Request 13364: [HELIX-147] Fix typo in Idealstate property
max_partitions_per_instance
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13364/#review24753
-----------------------------------------------------------
Ship it!
Ship It!
- Kanak Biscuitwala
On Aug. 6, 2013, 10:37 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13364/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 10:37 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Description
> -------
>
> Fix typo in Idealstate property max_partitions_per_instance
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/13364/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 13364: [HELIX-147] Fix typo in Idealstate property max_partitions_per_instance
Posted by kishore g <g....@gmail.com>.
Forgot about that, thanks.
On Tue, Aug 6, 2013 at 6:07 PM, Kanak Biscuitwala <ka...@hotmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13364/
>
> On August 7th, 2013, 1:04 a.m. UTC, *Kishore Gopalakrishna* wrote:
>
> why are the diff showing up as attachments? Makes it really hard to review
>
> It's a workaround for INFRA-6640. We've been attaching diffs to get around not being able to upload diffs the normal way.
>
>
> - Kanak
>
> On August 6th, 2013, 10:37 p.m. UTC, Zhen Zhang wrote:
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and
> Shi Lu.
> By Zhen Zhang.
>
> *Updated Aug. 6, 2013, 10:37 p.m.*
> Description
>
> Fix typo in Idealstate property max_partitions_per_instance
>
> Diffs
>
>
> View Diff <https://reviews.apache.org/r/13364/diff/>
> File Attachments
>
> - helix_2.diff<https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff>
>
>
Re: Review Request 13364: [HELIX-147] Fix typo in Idealstate property
max_partitions_per_instance
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
> On Aug. 7, 2013, 1:04 a.m., Kishore Gopalakrishna wrote:
> > why are the diff showing up as attachments? Makes it really hard to review
It's a workaround for INFRA-6640. We've been attaching diffs to get around not being able to upload diffs the normal way.
- Kanak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13364/#review24764
-----------------------------------------------------------
On Aug. 6, 2013, 10:37 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13364/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 10:37 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Description
> -------
>
> Fix typo in Idealstate property max_partitions_per_instance
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/13364/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 13364: [HELIX-147] Fix typo in Idealstate property
max_partitions_per_instance
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13364/#review24764
-----------------------------------------------------------
why are the diff showing up as attachments? Makes it really hard to review
- Kishore Gopalakrishna
On Aug. 6, 2013, 10:37 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13364/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 10:37 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Description
> -------
>
> Fix typo in Idealstate property max_partitions_per_instance
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/13364/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff
>
>
> Thanks,
>
> Zhen Zhang
>
>