You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/21 16:24:51 UTC

[GitHub] [nifi] mattyb149 opened a new pull request, #6142: NIFI-10141: Fix WriteJsonResult logging to show writer's schema

mattyb149 opened a new pull request, #6142:
URL: https://github.com/apache/nifi/pull/6142

   # Summary
   
   [NIFI-10141](https://issues.apache.org/jira/browse/NIFI-10141) The current error logging when a field cannot be written out uses the record's (i.e the record reader's) schema, which is not an accurate depiction of why the field cannot be written. Instead the record writer's schema should be used in the logging statement to show the schema used to write the record.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [x] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6142: NIFI-10141: Fix WriteJsonResult logging to show writer's schema

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6142:
URL: https://github.com/apache/nifi/pull/6142#issuecomment-1162344541

   Thanks @mattyb149 +1 merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6142: NIFI-10141: Fix WriteJsonResult logging to show writer's schema

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6142:
URL: https://github.com/apache/nifi/pull/6142#issuecomment-1161985810

   @mattyb149 I think it's important to include both the record's schema and the writer's schema. This way, if there's a mismatch it becomes clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #6142: NIFI-10141: Fix WriteJsonResult logging to show writer's schema

Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6142:
URL: https://github.com/apache/nifi/pull/6142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org