You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/26 18:52:30 UTC

[GitHub] mistercrunch commented on a change in pull request #4480: Add https support for Druid

mistercrunch commented on a change in pull request #4480: Add https support for Druid
URL: https://github.com/apache/incubator-superset/pull/4480#discussion_r170696185
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -107,24 +107,29 @@ def data(self):
             'backend': 'druid',
         }
 
+    @staticmethod
+    def get_base_url(host, port):
+        if not host.startswith('http'):
 
 Review comment:
   good call

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services