You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2025/05/16 21:35:41 UTC

[PR] NIFI-14577 Added INPUT_FILE_TYPE to list of supported property descriptors. [nifi]

dan-s1 opened a new pull request, #9956:
URL: https://github.com/apache/nifi/pull/9956

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-14577](https://issues.apache.org/jira/browse/NIFI-14577)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14577 Added Input File Type property descriptor to list of supported property descriptors. [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #9956:
URL: https://github.com/apache/nifi/pull/9956#issuecomment-2891067833

   > @exceptionfactory I certainly can make that change. I noticed also that REQUIRED_SHEETS is defined first yet in the list of property descriptors it actually comes after STARTING_ROW. Should STARTING_ROW also be defined first to match the list of property descriptors?
   
   Sure, that would be helpful, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14577 Added Input File Type property descriptor to list of supported property descriptors. [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #9956:
URL: https://github.com/apache/nifi/pull/9956#issuecomment-2891256008

   > If you don't mind, can we have both the defined and listed ordered as
   > 
   >     1. INPUT_FILE_TYPE
   > 
   >     2. PROTECTION_TYPE
   > 
   >     3. PASSWORD
   > 
   >     4. STARTING_ROW
   > 
   >     5. REQUIRED_SHEETS
   > 
   > 
   > as to me INPUT_FILE_TYPE, PROTECTION_TYPE and PASSWORD should be grouped together as they are not sheet specific information and it seems to me in a top down fashion should be specified before the actual sheet information.
   
   Sounds good, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14577 Added Input File Type property descriptor to list of supported property descriptors. [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #9956:
URL: https://github.com/apache/nifi/pull/9956#issuecomment-2891048412

   @exceptionfactory I certainly can make that change. I noticed also that REQUIRED_SHEETS is defined first yet in the list of property descriptors it actually comes after STARTING_ROW. Should STARTING_ROW also be defined first to match the list of property descriptors?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14577 Added Input File Type property descriptor to list of supported property descriptors. [nifi]

Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #9956:
URL: https://github.com/apache/nifi/pull/9956#issuecomment-2891114355

   If you don't mind, can we have both the defined and listed orders as
   
   1. INPUT_FILE_TYPE
   2. PROTECTION_TYPE
   3. PASSWORD
   4. STARTING_ROW
   5. REQUIRED_SHEETS
   
   as to me INPUT_FILE_TYPE, PROTECTION_TYPE and PASSWORD should be grouped together as they are not sheet specific information and it seems to me in a top down fashion should be specified before the actual sheet information. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14577 Added Input File Type property descriptor to list of supported property descriptors. [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #9956:
URL: https://github.com/apache/nifi/pull/9956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org