You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2026/08/26 08:41:07 UTC

[PR] [SPARK-59021] Add scg-store-memory and scg-pool-static crates [spark-connect-gateway]

viirya opened a new pull request, #11:
URL: https://github.com/apache/spark-connect-gateway/pull/11

   ### What changes were proposed in this pull request?
   
   Part of importing the Spark Connect Gateway reference implementation into
   `apache/spark-connect-gateway` as a series of small, bottom-up PRs (tracked in
   the do-not-merge reference PR #1).
   
   This adds two small crates that implement the `scg-routing` traits, grouped into
   one PR:
   
   - `scg-store-memory` — an in-process `AffinityStore` for single-replica
     deployments and tests (for multi-replica HA, `scg-store-redis`, added in a
     later PR, is used instead).
   - `scg-pool-static` — a backend `Pool` whose membership is fixed at startup (the
     dynamic K8s-Endpoints-watch variant `scg-pool-k8s` comes in a later PR).
   
   Both depend on the `scg-routing` crate whose traits they implement. They compile
   and test on their own (2 unit tests each) and are appended to the workspace
   `members` list. They are consumed later by the `proxy` crate (both are proxy
   dev-dependencies used by its tests).
   
   ### Why are the changes needed?
   
   Implements the reference gateway from the approved SPIP (SPARK-58455), imported
   one reviewable piece at a time.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   `cargo fmt --all --check`, `cargo clippy --workspace --all-targets -- -D warnings`,
   `cargo build --workspace`, and `cargo test --workspace` all pass locally
   (store-memory 2 tests, pool-static 2 tests).
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes, co-authored with Claude Code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59021] Add scg-store-memory and scg-pool-static crates [spark-connect-gateway]

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #11:
URL: https://github.com/apache/spark-connect-gateway/pull/11#issuecomment-5435416384

   Thanks @HyukjinKwon @dongjoon-hyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59021] Add scg-store-memory and scg-pool-static crates [spark-connect-gateway]

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #11: [SPARK-59021] Add scg-store-memory and scg-pool-static crates
URL: https://github.com/apache/spark-connect-gateway/pull/11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org