You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/09/30 03:38:08 UTC

Review Request 26162: Incorrect results for n-way join when join expressions are not in same order across joins

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26162/
-----------------------------------------------------------

Review request for hive and Harish Butani.


Bugs: HIVE-8298
    https://issues.apache.org/jira/browse/HIVE-8298


Repository: hive-git


Description
-------

Incorrect results for n-way join when join expressions are not in same order across joins


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2ed55c 
  ql/src/test/queries/clientpositive/join_merge_multi_expressions.q PRE-CREATION 
  ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/26162/diff/


Testing
-------

Added new test.


Thanks,

Ashutosh Chauhan


Re: Review Request 26162: Incorrect results for n-way join when join expressions are not in same order across joins

Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26162/#review54935
-----------------------------------------------------------

Ship it!


Ship It!

- Gunther Hagleitner


On Sept. 30, 2014, 1:38 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26162/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 1:38 a.m.)
> 
> 
> Review request for hive and Harish Butani.
> 
> 
> Bugs: HIVE-8298
>     https://issues.apache.org/jira/browse/HIVE-8298
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Incorrect results for n-way join when join expressions are not in same order across joins
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2ed55c 
>   ql/src/test/queries/clientpositive/join_merge_multi_expressions.q PRE-CREATION 
>   ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26162/diff/
> 
> 
> Testing
> -------
> 
> Added new test.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Re: Review Request 26162: Incorrect results for n-way join when join expressions are not in same order across joins

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26162/#review54942
-----------------------------------------------------------

Ship it!


Ship It!

- Harish Butani


On Sept. 30, 2014, 1:38 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26162/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 1:38 a.m.)
> 
> 
> Review request for hive and Harish Butani.
> 
> 
> Bugs: HIVE-8298
>     https://issues.apache.org/jira/browse/HIVE-8298
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Incorrect results for n-way join when join expressions are not in same order across joins
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2ed55c 
>   ql/src/test/queries/clientpositive/join_merge_multi_expressions.q PRE-CREATION 
>   ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26162/diff/
> 
> 
> Testing
> -------
> 
> Added new test.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>