You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/28 22:17:01 UTC
[GitHub] [incubator-gobblin] aplex commented on a change in pull request #3139: [GOBBLIN-1301] Add Azkaban OAuth token support
aplex commented on a change in pull request #3139:
URL: https://github.com/apache/incubator-gobblin/pull/3139#discussion_r513794805
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -175,18 +169,14 @@ public AzkabanJobLauncher(String jobId, Properties props)
this.props
.setProperty(ConfigurationKeys.JOB_TRACKING_URL_KEY, Strings.nullToEmpty(conf.get(AZKABAN_LINK_JOBEXEC_URL)));
- if (props.containsKey(JOB_TYPE) && JOB_TYPES_WITH_AUTOMATIC_TOKEN.contains(props.getProperty(JOB_TYPE))) {
- // Necessary for compatibility with Azkaban's hadoopJava job type
- // http://azkaban.github.io/azkaban/docs/2.5/#hadoopjava-type
- LOG.info(
- "Job type " + props.getProperty(JOB_TYPE) + " provides Hadoop tokens automatically. Using provided tokens.");
- if (System.getenv(HADOOP_TOKEN_FILE_LOCATION) != null) {
- this.props.setProperty(MAPREDUCE_JOB_CREDENTIALS_BINARY, System.getenv(HADOOP_TOKEN_FILE_LOCATION));
- }
+ if (System.getenv(HADOOP_TOKEN_FILE_LOCATION) != null) {
Review comment:
If the token is expired/incorrect/missing due to a bug or system problem, the job will fail when it tries to use it. I don't think we need to switch to internal authentication workflow in this case, as it can mask the original problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org