[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760200#comment-16760200 ] 

Michael Osipov edited comment on WAGON-541 at 2/4/19 8:45 PM:
--------------------------------------------------------------

bq. It seems like the main thrust of your concern was originally that so much of the message was repetitive information. What if you instead simply truncated the output and only showed the first 80 chars of the phrase?

Yes, I think that 90% of the users will see the very same information as the status code provided in contrast to {{Requested item is quarantined}}. The problem with 80 chars is that it won't simply scale. Given that almost all standard phrases are less than 80 chars, we'd we back at the beginning of message duplication. Having {{Access denied to: <dependency url>, ReasonPhrase: Forbidden}} does not add any value to the {{Access denied}}.

I am thinking of something like 

{code}
    <settings>
      <servers>
        <server>
          <id>my-server</id>
          <configuration>
            <showReasonPhrase>false</showReasonPhrase> <!-- boolean -->
          </configuration>
        </server>
      </servers>
    </settings>
{code}

This may work, but I need to evaluate this. I'd be happy if someone could provide a PR for this.


was (Author: michael-o):
bq. It seems like the main thrust of your concern was originally that so much of the message was repetitive information. What if you instead simply truncated the output and only showed the first 80 chars of the phrase?

Yes, I think that 90% of the users will see the very same information as the status code provided in contrast to {{Requested item is quarantined}}. The problem with 80 chars is that it won't simply scale. Given that almost all standard phrases are less than 80 chars, we'd we back at the beginning of message duplication. Having {{Access denied to: <dependency url> , ReasonPhrase: Forbidden}} does not add any value to the {{Access denied}}.

I am thinking of something like 

{code}
    <settings>
      <servers>
        <server>
          <id>my-server</id>
          <configuration>
            <showReasonPhrase>false</showReasonPhrase> <!-- boolean -->
          </configuration>
        </server>
      </servers>
    </settings>
{code}

This may work, but I need to evaluate this. I'd be happy if someone could provide a PR for this.

> Command Line Not Showing ReasonPhrase for Errors
> ------------------------------------------------
>
>                 Key: WAGON-541
>                 URL: https://issues.apache.org/jira/browse/WAGON-541
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 3.2.0
>         Environment: Windows 10
>            Reporter: Aurelie Pluche
>            Priority: Minor
>         Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG
>
>
> Hi,
> I work in the Azure DevOps Artifacts Packaging team at Microsoft where we provide a Maven service to our customers. We often use a Reason-Phrase to return information on failed requests to customers. This functionality was available in previous versions of maven but seems to have disappeared in Maven 3.6.0. Was this intentional?
> I have included screenshots of the cmd line response using two different maven versions (3.3.9 and 3.6.0). I intentionally made a call that would return a 405 error to be able to get an error response. I also used the same package.
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)