You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Hao Hao via Review Board <no...@reviews.apache.org> on 2020/01/06 05:51:14 UTC

Review Request 71954: RANGER-2684: Add Kudu service definition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/
-----------------------------------------------------------

Review request for ranger.


Repository: ranger


Description
-------

RANGER-2684: Add Kudu service definition


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java e96f881ac6798725a53ff4b44ef27330a3832fe9 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
  plugin-kudu/.gitignore PRE-CREATION 
  plugin-kudu/pom.xml PRE-CREATION 
  plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
  pom.xml abe8b751cb15ae86b1cb119d8aea9e919580cede 
  src/main/assembly/admin-web.xml 4658f87cf10529697a214b5766de555f9cd9ca14 


Diff: https://reviews.apache.org/r/71954/diff/1/


Testing
-------


Thanks,

Hao Hao

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/#review219257
-----------------------------------------------------------




agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json
Lines 100 (patched)
<https://reviews.apache.org/r/71954/#comment307417>

    "label": "DELETE",


- Abhay Kulkarni


On Jan. 6, 2020, 10:43 p.m., Hao Hao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71954/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2020, 10:43 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2684: Add Kudu service definition
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java e96f881ac6798725a53ff4b44ef27330a3832fe9 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
>   plugin-kudu/.gitignore PRE-CREATION 
>   plugin-kudu/pom.xml PRE-CREATION 
>   plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
>   pom.xml abe8b751cb15ae86b1cb119d8aea9e919580cede 
>   src/main/assembly/admin-web.xml 4658f87cf10529697a214b5766de555f9cd9ca14 
> 
> 
> Diff: https://reviews.apache.org/r/71954/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/#review219388
-----------------------------------------------------------




agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json
Lines 12 (patched)
<https://reviews.apache.org/r/71954/#comment307557>

    Ranger supports to maintain policy at Database level or table level resource alone. If that has to be done then we need to have "isValidLeaf": true" config at Database and table level resource.
    
    Please check the existing Hive resource for it.


- Ramesh Mani


On Jan. 21, 2020, 7:20 a.m., Hao Hao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71954/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2020, 7:20 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2684: Add Kudu service definition
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 2b007d2fefe2703ea2d97ad2e57c47e064c9e02a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
>   distro/src/main/assembly/admin-web.xml 37bda35aa74824dfcd01f870a9b02c794d0c7dc2 
>   plugin-kudu/.gitignore PRE-CREATION 
>   plugin-kudu/pom.xml PRE-CREATION 
>   plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
>   pom.xml f53c54df56323ca9e32069c3ebeabd79c3a9eb88 
> 
> 
> Diff: https://reviews.apache.org/r/71954/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/#review219508
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Jan. 31, 2020, 9:23 p.m., Hao Hao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71954/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2020, 9:23 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2684: Add Kudu service definition
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 2b007d2fefe2703ea2d97ad2e57c47e064c9e02a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
>   distro/src/main/assembly/admin-web.xml 37bda35aa74824dfcd01f870a9b02c794d0c7dc2 
>   plugin-kudu/.gitignore PRE-CREATION 
>   plugin-kudu/pom.xml PRE-CREATION 
>   plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
>   pom.xml f4cc712ae5330066acd755ddf24868355a3b5552 
> 
> 
> Diff: https://reviews.apache.org/r/71954/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/#review219479
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Jan. 31, 2020, 9:23 p.m., Hao Hao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71954/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2020, 9:23 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2684: Add Kudu service definition
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 2b007d2fefe2703ea2d97ad2e57c47e064c9e02a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
>   distro/src/main/assembly/admin-web.xml 37bda35aa74824dfcd01f870a9b02c794d0c7dc2 
>   plugin-kudu/.gitignore PRE-CREATION 
>   plugin-kudu/pom.xml PRE-CREATION 
>   plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
>   pom.xml f4cc712ae5330066acd755ddf24868355a3b5552 
> 
> 
> Diff: https://reviews.apache.org/r/71954/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Hao Hao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/
-----------------------------------------------------------

(Updated Jan. 31, 2020, 9:23 p.m.)


Review request for ranger.


Repository: ranger


Description
-------

RANGER-2684: Add Kudu service definition


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 2b007d2fefe2703ea2d97ad2e57c47e064c9e02a 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
  distro/src/main/assembly/admin-web.xml 37bda35aa74824dfcd01f870a9b02c794d0c7dc2 
  plugin-kudu/.gitignore PRE-CREATION 
  plugin-kudu/pom.xml PRE-CREATION 
  plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
  pom.xml f4cc712ae5330066acd755ddf24868355a3b5552 


Diff: https://reviews.apache.org/r/71954/diff/4/

Changes: https://reviews.apache.org/r/71954/diff/3-4/


Testing
-------


Thanks,

Hao Hao

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Hao Hao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/
-----------------------------------------------------------

(Updated Jan. 21, 2020, 7:20 a.m.)


Review request for ranger.


Repository: ranger


Description
-------

RANGER-2684: Add Kudu service definition


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 2b007d2fefe2703ea2d97ad2e57c47e064c9e02a 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
  distro/src/main/assembly/admin-web.xml 37bda35aa74824dfcd01f870a9b02c794d0c7dc2 
  plugin-kudu/.gitignore PRE-CREATION 
  plugin-kudu/pom.xml PRE-CREATION 
  plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
  pom.xml f53c54df56323ca9e32069c3ebeabd79c3a9eb88 


Diff: https://reviews.apache.org/r/71954/diff/3/

Changes: https://reviews.apache.org/r/71954/diff/2-3/


Testing
-------


Thanks,

Hao Hao

Re: Review Request 71954: RANGER-2684: Add Kudu service definition

Posted by Hao Hao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/
-----------------------------------------------------------

(Updated Jan. 6, 2020, 10:43 p.m.)


Review request for ranger.


Repository: ranger


Description
-------

RANGER-2684: Add Kudu service definition


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java e96f881ac6798725a53ff4b44ef27330a3832fe9 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json PRE-CREATION 
  plugin-kudu/.gitignore PRE-CREATION 
  plugin-kudu/pom.xml PRE-CREATION 
  plugin-kudu/src/main/java/org/apache/ranger/services/kudu/RangerServiceKudu.java PRE-CREATION 
  pom.xml abe8b751cb15ae86b1cb119d8aea9e919580cede 
  src/main/assembly/admin-web.xml 4658f87cf10529697a214b5766de555f9cd9ca14 


Diff: https://reviews.apache.org/r/71954/diff/2/

Changes: https://reviews.apache.org/r/71954/diff/1-2/


Testing
-------


Thanks,

Hao Hao