[jira] [Commented] (PHOENIX-5933) Rename VIEW_TTL property to be PHOENIX_TTL

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158716#comment-17158716 ] 

Hadoop QA commented on PHOENIX-5933:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13007727/PHOENIX-5933.4.x.001.patch
  against 4.x branch at commit 22a46f7233c4169ff4bb815cf3cdb1c44ca6b100.
  ATTACHMENT ID: 13007727

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 0 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    private void assertViewHeaderRowsHavePhoenixTTLRelatedCells(String schemaName, long minTimestamp,
+        QualifierFilter phoenixTTLQualifierFilter = new QualifierFilter(CompareFilter.CompareOp.EQUAL,
+    private void assertSyscatHavePhoenixTTLRelatedColumns(String tenantId, String schemaName, String tableName, String tableType, long ttlValueExpected)
+            String sql = String.format(PHOENIX_TTL_HEADER_SQL, tenantClause, schemaName, tableName, tableType);
+        // Since the PHOENIX_TTL property values are not being set, we expect the view header columns to show up in raw scans only.
+        assertViewHeaderRowsHavePhoenixTTLRelatedCells(schemaBuilder.getTableOptions().getSchemaName(), startTime, true, 2);
+            assertEquals(SQLExceptionCode.CANNOT_SET_OR_ALTER_PHOENIX_TTL_FOR_TABLE_WITH_TTL.getErrorCode(), e.getErrorCode());
+            assertEquals(SQLExceptionCode.PHOENIX_TTL_SUPPORTED_FOR_VIEWS_ONLY.getErrorCode(), e.getErrorCode());
+        // Since the PHOENIX_TTL property values are being set, we expect the view header columns to show up in regular scans too.
+        assertViewHeaderRowsHavePhoenixTTLRelatedCells(schemaBuilder.getTableOptions().getSchemaName(), startTime, false, 2);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4037//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4037//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4037//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4037//console

This message is automatically generated.

> Rename VIEW_TTL property to be PHOENIX_TTL
> ------------------------------------------
>
>                 Key: PHOENIX-5933
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5933
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Jacob Isaac
>            Assignee: Jacob Isaac
>            Priority: Major
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5933.4.x.001.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> As there is more interest in extending the TTL feature to all Phoenix entities (tables and views)
> More specifically separate the usage of Phoenix application-level TTL (row-based) and HBase level TTL (Store/Column Family-based).
> It makes sense to rename the Phoenix Table property to be PHOENIX_TTL



--
This message was sent by Atlassian Jira
(v8.3.4#803005)