You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Martin Zink (Code Review)" <ge...@cloudera.org> on 2020/05/15 12:46:03 UTC

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Martin Zink has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15877


Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct
  Separated "||" and "OR" into different tokens.
    -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

    -|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands
      CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
      CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly so its needs to be replaced by its
      CompoundPredicate or FunctionCallExpr member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
7 files changed, 189 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 12:

(11 comments)

Hell... I thought when I publish the next patchset gerrit will finalize the draft commands. Sorry about that.

http://gerrit.cloudera.org:8080/#/c/15877/9//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15877/9//COMMIT_MSG@7
PS9, Line 7: IMPALA-452: Add support for string concatenation operator using ||
> commit message is still weirdly formatted. https://cwiki.apache.org/conflue
Done


http://gerrit.cloudera.org:8080/#/c/15877/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15877/10//COMMIT_MSG@22
PS10, Line 22: 
> I compared the behaviour of this operator to postgres and hive, and it look
Yeah that is a good idea, I will also check out the different behaviors of different SQL parsers regarding the implicit casts.
Follow-up Jira seems a good way, I would love to work on that.


http://gerrit.cloudera.org:8080/#/c/15877/10//COMMIT_MSG@22
PS10, Line 22: 
> We should also add some more tests to AnalyzeExprsTest.java that test both 
I've added a bunch of positive and negative test cases to AnalyzeExprsTest


http://gerrit.cloudera.org:8080/#/c/15877/9/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/9/be/src/exprs/expr-test.cc@3892
PS9, Line 3892: (
> nit: we don't usually have a space before parentheses here and below. It's 
Yeah old habits die hard, didn't know about the clang tidy this should not be an issue anymore thanks :)


http://gerrit.cloudera.org:8080/#/c/15877/10/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/10/be/src/exprs/expr-test.cc@3893
PS10, Line 3893:   TestStringValue("cast('foo  ' AS CHAR(5)) || '3'", "foo  3");
> Can you add some tests for string concatenation with NULL STRING arguments?
Originally OR accepted NULL so I've kept that argument type solely for the logical OR version. (changing the least amount compared to previous behaviour). I've added some test cases here and to AnalyzeStmtsTest.java as well to reflect this behavior.


http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc@3893
PS11, Line 3893:   TestStringValue("cast('foo  ' AS CHAR(5)) || '3'", "foo  3");
> I think we also want a positive test case, e.g.
Done


http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc@3896
PS11, Line 3896:   TestIsNull("cast(NULL AS STRING) || 'abc'", TYPE_STRING);
> Also the reverse, i.e. 'abc' || NULL. Since the condition in the planner ch
Done


http://gerrit.cloudera.org:8080/#/c/15877/9/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/9/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@33
PS9, Line 33: 
> Can you comment that this is initialized during analysis.
Done


http://gerrit.cloudera.org:8080/#/c/15877/10/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/10/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@80
PS10, Line 80:       encapsulatedExpr_.analyze(analyzer);
> It's weird that we get different errors for, say string || int, vs int || s
Agreed, I also reworked the error message to reflect that both CHAR, and VARCHAR can be parsed with STRINGs (reflecting how isStringType() works)


http://gerrit.cloudera.org:8080/#/c/15877/10/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:

http://gerrit.cloudera.org:8080/#/c/15877/10/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@849
PS10, Line 849:     RewritesOk("FALSE || id = 0", extractCompoundVerticalBarExprRule, "FALSE OR id = 0");
> Can we add a few more test cases for mixed types. E.g. a couple of cases of
Sure, I've added those test cases to AnalyzeStmtsTest.java (they would not fit here, because they fail during analysis not rewrite phase)


http://gerrit.cloudera.org:8080/#/c/15877/9/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

http://gerrit.cloudera.org:8080/#/c/15877/9/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3099
PS9, Line 3099: select distinct bool_col || int_col < smallint_col,
> Can you reformat this so that it's more readable (i.e. not all one one line
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 12
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2020 20:14:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6159/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 13:07:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 11: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 20:37:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct
  Separated "||" and "OR" into different tokens.
    -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

    -|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands
      CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
      CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly so its needs to be replaced by its
      CompoundPredicate or FunctionCallExpr member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
7 files changed, 194 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6351/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 16:04:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 11:

I can +2 after that...


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jun 2020 18:51:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 11:

(2 comments)

Looks like you need to rebase. I think a couple more test cases would be good too (unit tests are cheap to add and run, correctness bugs are a real problem).

http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc@3893
PS11, Line 3893:   TestStringValue("cast('foo  ' AS CHAR(5)) || '3'", "foo  3");
I think we also want a positive test case, e.g.

  cast(NULL as string) || 'abc'
  'abc' ||  cast(NULL as string)


http://gerrit.cloudera.org:8080/#/c/15877/11/be/src/exprs/expr-test.cc@3896
PS11, Line 3896:   TestError("NULL || 'xyz'");
Also the reverse, i.e. 'abc' || NULL. Since the condition in the planner checks the two children separately.



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jun 2020 18:51:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................

IMPALA-452: Add support for string concatenation operator using ||

Separated "||" and "OR" into different tokens.
OR (KW_OR) remains the same. (it creates CompoundPredicate
and expects two BOOLEAN operands)
|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr
which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate
or a FunctionCallExpr member variable based on the type
of the left operand during analyze.

Similarly to BetweenPredicate it cannot be executed directly
so its needs to be replaced by its member variable
by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
12 files changed, 405 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/11
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@96
PS4, Line 96: 	    "or 'STRING' but returns type '%s'.",
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:

http://gerrit.cloudera.org:8080/#/c/15877/4/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@831
PS4, Line 831: 	    = ExtractCompoundVerticalBarExprRule.INSTANCE;
tab used for whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 07:23:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 7:

Let me know when I should take another look (I generally wait until all the comments have been replied to).


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 19:04:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5907/


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 16:37:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 12
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2020 20:38:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6091/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 14:39:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 7:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6160/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 13:11:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5907/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 12:41:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct
  Separated "||" and "OR" into different tokens.
    -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

    -|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands
      CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
      CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly so its needs to be replaced by its
      CompoundPredicate or FunctionCallExpr member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
7 files changed, 194 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens.
-OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
-|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly
so its needs to be replaced by its member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
11 files changed, 244 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@94
PS3, Line 94:       throw new AnalysisException(String.format("Operand '%s' part of CompoundVerticalBarExpr " +
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:

http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@830
PS3, Line 830:     ExprRewriteRule extractCompoundVerticalBarExprRule = ExtractCompoundVerticalBarExprRule.INSTANCE;
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/15877/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java@842
PS3, Line 842:     RewritesOk("string_col || 'TEST'", extractCompoundVerticalBarExprRule, "concat(string_col, 'TEST')");
line too long (105 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 12:46:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................

IMPALA-452: Add support for string concatenation operator using ||

Separated "||" and "OR" into different tokens.
OR (KW_OR) remains the same. (it creates CompoundPredicate
and expects two BOOLEAN operands)
|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr
which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate
or a FunctionCallExpr member variable based on the type
of the left operand during analyze.

Similarly to BetweenPredicate it cannot be executed directly
so its needs to be replaced by its member variable
by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
12 files changed, 416 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/12
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 12
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 5:

(9 comments)

This will be great to have. The overall approach of instantiating a wrapper and then replacing during rewrites makes sense to me.

http://gerrit.cloudera.org:8080/#/c/15877/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15877/5//COMMIT_MSG@11
PS5, Line 11:     -|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands
nit: formatting of commit message is weird.


http://gerrit.cloudera.org:8080/#/c/15877/5//COMMIT_MSG@15
PS5, Line 15: 
I think this patch needs more tests -it needs tests that it returns the correct results in more cases - for different data types, etc, in expr-test.cc. It'd also be good to add at least one end-to-end test in test_exprs.py (probably it would live in exprs.test) to make sure it works end-to-end (we have had cases before where exprs work fine in all the tests, but something wasn't set up right for them to work when running in the context of a real query).


http://gerrit.cloudera.org:8080/#/c/15877/5//COMMIT_MSG@17
PS5, Line 17: 
Can you also add some cases for ToSqlTest.java to make sure that that works as expected.


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@33
PS5, Line 33: logicalOR
nit: members have trailing _ in our Java coding style


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@34
PS5, Line 34:   private FunctionCallExpr concatFunctionCall;
Why not just have a single member of type Expr. I think that would reduce the amount of code below significantly - you wouldn't need all the if () statements.


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@40
PS5, Line 40:       children_.add(e1);
nit: indentation is off


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@85
PS5, Line 85:  
nit: space after getType


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
File fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java:

http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java@31
PS5, Line 31: 
nit: inconsistent blank line


http://gerrit.cloudera.org:8080/#/c/15877/5/fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java@41
PS5, Line 41:  
nit: whitespace before ()



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 19:35:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6079/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 13:38:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens.
-OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
-|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly
so its needs to be replaced by its member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
10 files changed, 241 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 12
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2020 21:36:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6088/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 08:17:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15877/6/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/6/be/src/exprs/expr-test.cc@3900
PS6, Line 3900:   TestError ("cast('2011-10-22 09:10:11' as timestamp) || cast('2016-10-22 09:10:11' as timestamp)");
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/15877/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java:

http://gerrit.cloudera.org:8080/#/c/15877/6/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@329
PS6, Line 329:       
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 11:58:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5842/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 12:46:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15877/9//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15877/9//COMMIT_MSG@7
PS9, Line 7: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens.
commit message is still weirdly formatted. https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala has some guidelines:

  Finally, please write a good, clear commit message, with a short, descriptive title and a message that is exactly long enough to explain what the problem was, and how it was fixed. Each should have 72 or fewer characters if possible. The first line should have an empty line after it, and the first line should begin with the ticket(s) addressed, followed by a colon and a space: "IMPALA-1234: ". Docs-only commits should have [DOCS] after the ticket numbers, like "IMPALA-1234: [DOCS] ".  Here is an example of a good commit message:


http://gerrit.cloudera.org:8080/#/c/15877/9/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/15877/9/be/src/exprs/expr-test.cc@3892
PS9, Line 3892:  
nit: we don't usually have a space before parentheses here and below. It's probably worth running clang-format on your patches - it automates some of this minor stuff

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536


http://gerrit.cloudera.org:8080/#/c/15877/9/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
File fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java:

http://gerrit.cloudera.org:8080/#/c/15877/9/fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java@33
PS9, Line 33:   private Expr encapsulatedExpr_;
Can you comment that this is initialized during analysis.


http://gerrit.cloudera.org:8080/#/c/15877/9/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

http://gerrit.cloudera.org:8080/#/c/15877/9/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3099
PS9, Line 3099: select distinct bool_col || int_col < smallint_col, "TEST" || string_col from functional.alltypes WHERE float_col = double_col || (string_col || 'test') = 'testtest';
Can you reformat this so that it's more readable (i.e. not all one one line). Same for the one below.



-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jun 2020 00:58:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Martin Zink (Code Review)" <ge...@cloudera.org>.
Martin Zink has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................

IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens.
-OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
-|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly
so its needs to be replaced by its member variable by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
10 files changed, 240 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct   Separated "||" and "OR" into different tokens.     -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 18:12:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6210/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 9
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2020 08:23:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-452: Add support for string concatenation operator using ||

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15877 )

Change subject: IMPALA-452: Add support for string concatenation operator using ||
......................................................................

IMPALA-452: Add support for string concatenation operator using ||

Separated "||" and "OR" into different tokens.
OR (KW_OR) remains the same. (it creates CompoundPredicate
and expects two BOOLEAN operands)
|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr
which expects two BOOLEAN operands or two STRING operands

CompoundVerticalBarExpr creates either a CompoundPredicate
or a FunctionCallExpr member variable based on the type
of the left operand during analyze.

Similarly to BetweenPredicate it cannot be executed directly
so its needs to be replaced by its member variable
by ExtractCompoundVerticalBarExprRule.

Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Reviewed-on: http://gerrit.cloudera.org:8080/15877
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
12 files changed, 416 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 13
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>