[GitHub] [airflow] ashb opened a new pull request #6307: [AIRFLOW-5634] Don't allow disabled fields to be edited in DagModelView

[GitBox <gi...@apache.org>]

ashb opened a new pull request #6307: [AIRFLOW-5634] Don't allow disabled fields to be edited in DagModelView
URL: https://github.com/apache/airflow/pull/6307
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-5634
   
   ### Description
   
   - [x] If someone plays silly games and edits the HTML (or crafts a request) to
   the DAG model it is possible to edit fields that aren't meant to be
   edited, leading to odd to debug behaviour
   
     Against v1-10-stable as this only applies to the classic UI. Separate PR coming for RBAC UI (where I will just disable the ability to edit the DagModel. I could do the same here )
   
   ### Tests
   
   - [x] Tests added
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services