You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/18 11:42:36 UTC

[GitHub] [superset] kgabryje opened a new pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

kgabryje opened a new pull request #12582:
URL: https://github.com/apache/superset/pull/12582


   ### SUMMARY
   Currently a user can edit a name of saved metric in popover, but the change doesn't show anywhere, because this feature is not implemented for saved metrics yet. This PR disables name edit feature for saved metrics.
   Also, now "Saved" is a default tab in Metrics popover. When user opens a popover, "Saved" tab is selected by default, unless there are no saved metrics for current dataset.
   Closes https://github.com/apache/superset/issues/12578
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   https://user-images.githubusercontent.com/15073128/104911028-8532f400-598a-11eb-89d8-2e3f0117f649.mov
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/superset/issues/12578
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc @villebro @ktmud 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `3.30%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   63.44%   -3.31%     
   ==========================================
     Files        1015      486     -529     
     Lines       49634    29966   -19668     
     Branches     4839        0    -4839     
   ==========================================
   - Hits        33131    19012   -14119     
   + Misses      16380    10954    -5426     
   + Partials      123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.44% <ø> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
   | [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | | |
   | [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | | |
   | [...t-frontend/src/components/DynamicPlugins/index.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvaW5kZXgudHN4) | | |
   | [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | | |
   | ... and [519 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762970902


   @kgabryje can we make the title change more "responsive", i.e. change as soon as users have selected an item from the dropdown or switched tabs?  Not a blocker if it requires too much refactoring, though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (9379d77) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `17.73%`.
   > The diff coverage is `7.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12582       +/-   ##
   ===========================================
   - Coverage   66.75%   49.01%   -17.74%     
   ===========================================
     Files        1015      473      -542     
     Lines       49634    16918    -32716     
     Branches     4839     4359      -480     
   ===========================================
   - Hits        33131     8293    -24838     
   + Misses      16380     8625     -7755     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `49.01% <7.40%> (-1.97%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `6.25% <0.00%> (-83.75%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `53.57% <0.00%> (-37.61%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `37.42% <0.00%> (-52.71%)` | :arrow_down: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `7.20% <6.25%> (-66.53%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `76.47% <100.00%> (-17.65%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | ... and [878 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...9379d77](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762391555


   > It is a little strange to adjust the order of tabs depending on whether the dataset contains saved metrics or not.
   > 
   > thank you for your fix.
   
   right.......we should add tooltip or even enable user to save a ad hoc metric to saved metrics in the popover in the near future. 
   as i'm getting more familiar with Superset, i do see advanced and enterprise users tend to use saved metrics more often. placing Saved tab first in the modal can encourage users to use and create reusable metrics across team and organization. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (de0beb9) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `6.01%`.
   > The diff coverage is `60.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   60.73%   -6.02%     
   ==========================================
     Files        1015      529     -486     
     Lines       49634    19662   -29972     
     Branches     4839     4844       +5     
   ==========================================
   - Hits        33131    11942   -21189     
   + Misses      16380     7523    -8857     
   - Partials      123      197      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `60.73% <60.71%> (-0.01%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `53.96% <50.00%> (-19.77%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `82.31% <66.66%> (-7.81%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <100.00%> (-23.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [680 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...de0beb9](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763093888


   > I thought that for now current solution would be sufficient and we could address "responsiveness" later as a separate issue. WDYT?
   
   Agreed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje closed pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #12582:
URL: https://github.com/apache/superset/pull/12582


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762686671


   > +1 on allowing saving adhoc metric in place.
   > 
   > I think this PR looks great. Just one more thing, can we show the name (or verbose name if available) of the saved metric instead of "My metric"?
   
   Agreed, this would be really nice. Also, showing "My Metric" for simple/custom metrics is slightly confusing as the metric will not show up as such on the chart. It might be more intuitive to show the title as it will be rendered with a dark grey color if the user hasn't provided a custom title to show what the metric will actually be called. In the screenshot below we would show "MAX(gender)" instead of "My Metric" in the title.
   ![image](https://user-images.githubusercontent.com/33317356/105008349-c9cd9680-5a41-11eb-90e4-a275d79a2fdc.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762457142


   +1 on allowing saving adhoc metric in place.
   
   I think this PR looks great. Just one more thing, can we show the name (or verbose name if available) of the saved metric instead of "My metric"? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] adam-stasiak commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762275221


   Tested manually - Order of tabs has changed in compare to old version 🍏 and title is not editable for saved tab 🟢 .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zhaoyongjie commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762298118


   It is a little strange to adjust the order of tabs depending on whether the dataset contains saved metrics or not.
   
   thank you for your fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `1.71%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   65.03%   -1.72%     
   ==========================================
     Files        1015     1015              
     Lines       49634    49708      +74     
     Branches     4839     4874      +35     
   ==========================================
   - Hits        33131    32327     -804     
   - Misses      16380    17230     +850     
   - Partials      123      151      +28     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `44.95% <8.69%> (-6.03%)` | :arrow_down: |
   | javascript | `60.73% <58.82%> (-0.01%)` | :arrow_down: |
   | python | `63.44% <ø> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `38.82% <39.28%> (-34.90%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.14% <66.66%> (-5.98%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `82.35% <100.00%> (-11.77%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
   | ... and [87 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc merged pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #12582:
URL: https://github.com/apache/superset/pull/12582


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763087513


   @ktmud That was my plan at first, but we keep current values of edited metrics in a state of component that is a sibling of popover title component. So we'd have to either pass the state to a parent and down to popover title or move the edited metric's state to parent component (perhaps with Context API?). I thought that for now current solution would be sufficient and we could address "responsiveness" later as a separate issue. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (b7ce08f) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `7.78%`.
   > The diff coverage is `78.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   58.96%   -7.79%     
   ==========================================
     Files        1015      959      -56     
     Lines       49634    46888    -2746     
     Branches     4839     4359     -480     
   ==========================================
   - Hits        33131    27647    -5484     
   - Misses      16380    19241    +2861     
   + Partials      123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `51.02% <85.18%> (+0.04%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `63.44% <50.00%> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `88.88% <ø> (-1.81%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `55.21% <0.00%> (-34.91%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.23% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.29% <50.00%> (-0.08%)` | :arrow_down: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `77.60% <93.75%> (+3.87%)` | :arrow_up: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `90.62% <100.00%> (+0.62%)` | :arrow_up: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `92.85% <100.00%> (+1.68%)` | :arrow_up: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `88.23% <100.00%> (-5.89%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [394 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...de0beb9](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762631986


   > +1 on allowing saving adhoc metric in place.
   
   will have to wait until metrics refactoring work is done. @zhaoyongjie 
   
   @kgabryje let's show the metrics' name on the popover. that will be the scope of this PR. oh and please fix the failing test. thanks both! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `4.38%`.
   > The diff coverage is `58.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   62.37%   -4.39%     
   ==========================================
     Files        1015     1015              
     Lines       49634    49634              
     Branches     4839     4849      +10     
   ==========================================
   - Hits        33131    30957    -2174     
   - Misses      16380    18480    +2100     
   - Partials      123      197      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `60.73% <58.82%> (-0.01%)` | :arrow_down: |
   | python | `63.44% <ø> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `53.78% <50.00%> (-19.95%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `82.31% <66.66%> (-7.81%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <100.00%> (-23.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [199 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `1.29%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   65.45%   -1.30%     
   ==========================================
     Files        1015     1015              
     Lines       49634    49708      +74     
     Branches     4839     4874      +35     
   ==========================================
   - Hits        33131    32536     -595     
   - Misses      16380    17032     +652     
   - Partials      123      140      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `49.13% <8.69%> (-1.85%)` | :arrow_down: |
   | javascript | `60.73% <58.82%> (-0.01%)` | :arrow_down: |
   | python | `63.44% <ø> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `38.82% <39.28%> (-34.90%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.14% <66.66%> (-5.98%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `82.35% <100.00%> (-11.77%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
   | [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.34% <0.00%> (-48.83%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [59 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762954489


   @ktmud @junlincc @villebro Done
   
   https://user-images.githubusercontent.com/15073128/105062356-d0c4cb00-5a7a-11eb-9360-ca224491770e.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763202521


   @kgabryje @junlincc Found a bug one this one: opening a selected adhoc metric should open the SIMPLE or CUSTOM tab, but now it always opens the SAVED tab.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (9379d77) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `8.68%`.
   > The diff coverage is `7.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   58.06%   -8.69%     
   ==========================================
     Files        1015      959      -56     
     Lines       49634    46882    -2752     
     Branches     4839     4359     -480     
   ==========================================
   - Hits        33131    27222    -5909     
   - Misses      16380    19660    +3280     
   + Partials      123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `49.01% <7.40%> (-1.97%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.17% <ø> (-0.79%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `6.25% <0.00%> (-83.75%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `53.57% <0.00%> (-37.61%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `37.42% <0.00%> (-52.71%)` | :arrow_down: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `7.20% <6.25%> (-66.53%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `76.47% <100.00%> (-17.65%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | ... and [413 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...9379d77](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `3.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   63.41%   -3.34%     
   ==========================================
     Files        1015      486     -529     
     Lines       49634    29951   -19683     
     Branches     4839        0    -4839     
   ==========================================
   - Hits        33131    18993   -14138     
   + Misses      16380    10958    -5422     
   + Partials      123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.41% <ø> (-0.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
   | [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
   | [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
   | ... and [530 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (de0beb9) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `4.51%`.
   > The diff coverage is `60.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   62.23%   -4.52%     
   ==========================================
     Files        1015     1015              
     Lines       49634    49630       -4     
     Branches     4839     4844       +5     
   ==========================================
   - Hits        33131    30888    -2243     
   - Misses      16380    18545    +2165     
   - Partials      123      197      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `60.73% <60.71%> (-0.01%)` | :arrow_down: |
   | python | `63.22% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `53.96% <50.00%> (-19.77%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `82.31% <66.66%> (-7.81%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <100.00%> (-23.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [216 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...de0beb9](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762631986


   > +1 on allowing saving adhoc metric in place.
   
   will have to wait until metrics refactoring work is done. @zhaoyongjie 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763087513


   @ktmud That was my plan at first, but we keep current values of edited metrics in a state of component that is a sibling of popover title component (`AdhocMetricEditPopover`). So we'd have to either pass the state to a parent and down to popover title or move the edited metric's state to parent component (perhaps with Context API?). I thought that for now current solution would be sufficient and we could address "responsiveness" later as a separate issue. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (9379d77) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `18.11%`.
   > The diff coverage is `7.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12582       +/-   ##
   ===========================================
   - Coverage   66.75%   48.64%   -18.12%     
   ===========================================
     Files        1015      473      -542     
     Lines       49634    16918    -32716     
     Branches     4839     4359      -480     
   ===========================================
   - Hits        33131     8229    -24902     
   + Misses      16380     8689     -7691     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `48.64% <7.40%> (-2.35%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `6.25% <0.00%> (-83.75%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `53.57% <0.00%> (-37.61%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `37.42% <0.00%> (-52.71%)` | :arrow_down: |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `7.20% <6.25%> (-66.53%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `76.47% <100.00%> (-17.65%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | ... and [878 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...9379d77](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (a772753) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `4.27%`.
   > The diff coverage is `60.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   62.47%   -4.28%     
   ==========================================
     Files        1015     1015              
     Lines       49634    49628       -6     
     Branches     4839     4844       +5     
   ==========================================
   - Hits        33131    31007    -2124     
   - Misses      16380    18424    +2044     
   - Partials      123      197      +74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `60.73% <60.71%> (-0.01%)` | :arrow_down: |
   | python | `63.62% <ø> (-0.34%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `53.96% <50.00%> (-19.77%)` | :arrow_down: |
   | [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `74.28% <50.00%> (-16.90%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `82.31% <66.66%> (-7.81%)` | :arrow_down: |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `68.75% <83.33%> (-21.25%)` | :arrow_down: |
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.58% <100.00%> (-23.53%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [197 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...9379d77](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=h1) Report
   > Merging [#12582](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=desc) (af59c8a) into [master](https://codecov.io/gh/apache/superset/commit/0f243c6ddd2860ba475ba205eb5bfd836833a9a8?el=desc) (0f243c6) will **decrease** coverage by `3.38%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12582/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12582      +/-   ##
   ==========================================
   - Coverage   66.75%   63.36%   -3.39%     
   ==========================================
     Files        1015      486     -529     
     Lines       49634    29951   -19683     
     Branches     4839        0    -4839     
   ==========================================
   - Hits        33131    18978   -14153     
   + Misses      16380    10973    -5407     
   + Partials      123        0     -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.36% <ø> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.65% <0.00%> (-0.93%)` | :arrow_down: |
   | ... and [534 more](https://codecov.io/gh/apache/superset/pull/12582/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=footer). Last update [0f243c6...a772753](https://codecov.io/gh/apache/superset/pull/12582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763202521


   @kgabryje @junlincc Found a bug on this one: opening a selected adhoc metric should open the SIMPLE or CUSTOM tab, but now it always opens the SAVED tab.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762225107






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org