You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/11/14 06:00:01 UTC

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3437: [CARBONDATA-3530] Support Create timeseries MV Datamap with the supported granularity levels.

ajantha-bhat commented on a change in pull request #3437: [CARBONDATA-3530] Support Create timeseries MV Datamap with the supported granularity levels.
URL: https://github.com/apache/carbondata/pull/3437#discussion_r346138077
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala
 ##########
 @@ -43,9 +45,14 @@ import org.apache.carbondata.mv.rewrite.{SummaryDataset, SummaryDatasetCatalog}
 class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
 
   // TODO Find way better way to get the provider.
-  private val dataMapProvider =
+  private val dataMapProvider: java.util.List[DataMapProvider] = new util
 
 Review comment:
   better to rename it as **dataMapProviderList**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services