You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/03 13:27:26 UTC

[GitHub] XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support

XD-DENG commented on a change in pull request #4429: [AIRFLOW-3625] Add Redis Cluster support
URL: https://github.com/apache/incubator-airflow/pull/4429#discussion_r244997369
 
 

 ##########
 File path: airflow/contrib/hooks/redis_cluster_hook.py
 ##########
 @@ -0,0 +1,86 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+RedisClusterHook module
+"""
+from rediscluster import StrictRedisCluster
+from airflow.exceptions import AirflowException
+from airflow.hooks.base_hook import BaseHook
+from airflow.utils.log.logging_mixin import LoggingMixin
+
+
+class RedisClusterHook(BaseHook, LoggingMixin):
+    """
+    Hook to interact with Redis Cluster
+
+    Note: If the Redis Cluster is launched in AWS Elasticache,
+    the hook must be initialized with skip_full_coverage_check=True option.
+    This is because AWS disallowed the CONFIG command in the Redis Cluster.
+    """
+    def __init__(self, redis_cluster_conn_id='redis_cluster_default', **kwargs):
+        """
+        Prepares hook to connect to a Redis Cluster.
+
+        :param conn_id: the name of the connection that has the parameters
+                        we need to connect to Redis Cluster.
+        :type conn_id: str
+
 
 Review comment:
   This empty line in docstring is not necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services