[GitHub] andrzej-kaczmarek commented on a change in pull request #310: nimble/ll: Minor improvement on handling LL_FEATURE_REQ

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #310: nimble/ll: Minor improvement on handling LL_FEATURE_REQ
URL: https://github.com/apache/mynewt-nimble/pull/310#discussion_r251711521
 
 

 ##########
 File path: nimble/controller/src/ble_ll_ctrl.c
 ##########
 @@ -1685,12 +1685,13 @@ ble_ll_ctrl_initiate_dle(struct ble_ll_conn_sm *connsm)
  * @param dptr
  * @param rspbuf
  * @param opcode
+ * @param initiate_dle
  *
  * @return int
  */
 static int
 ble_ll_ctrl_rx_feature_req(struct ble_ll_conn_sm *connsm, uint8_t *dptr,
-                           uint8_t *rspbuf, uint8_t opcode)
+                           uint8_t *rspbuf, uint8_t opcode, uint8_t *initiate_dle)
 
 Review comment:
   I'd name this just as a generic flag to indicate that features were initialized by this LL op

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services