You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2022/07/22 07:34:37 UTC

[GitHub] [unomi] sergehuber opened a new pull request, #463: UNOMI-631 Map sources to scopes

sergehuber opened a new pull request, #463:
URL: https://github.com/apache/unomi/pull/463

   - Remove SourceItem and SourceService and replace with Scope and ScopeService
   - Map all GraphQL CDPSource operations to Scope and ScopeService
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber merged pull request #463: UNOMI-631 Map sources to scopes

Posted by GitBox <gi...@apache.org>.
sergehuber merged PR #463:
URL: https://github.com/apache/unomi/pull/463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] jkevan commented on a diff in pull request #463: UNOMI-631 Map sources to scopes

Posted by GitBox <gi...@apache.org>.
jkevan commented on code in PR #463:
URL: https://github.com/apache/unomi/pull/463#discussion_r927393992


##########
api/src/main/java/org/apache/unomi/api/Event.java:
##########
@@ -398,12 +393,10 @@ public void setFlattenedProperties(Map<String, Object> flattenedProperties) {
     /**
      * @return the scope
      */
-    @Deprecated
     public String getScope() {
         return scope;
     }
 
-    @Deprecated
     public void setScope(String scope) {
         this.scope = scope;
     }

Review Comment:
   I think this setter/getter can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber commented on a diff in pull request #463: UNOMI-631 Map sources to scopes

Posted by GitBox <gi...@apache.org>.
sergehuber commented on code in PR #463:
URL: https://github.com/apache/unomi/pull/463#discussion_r927401846


##########
api/src/main/java/org/apache/unomi/api/Event.java:
##########
@@ -398,12 +393,10 @@ public void setFlattenedProperties(Map<String, Object> flattenedProperties) {
     /**
      * @return the scope
      */
-    @Deprecated
     public String getScope() {
         return scope;
     }
 
-    @Deprecated
     public void setScope(String scope) {
         this.scope = scope;
     }

Review Comment:
   Good catch, since they are in the parent class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org