[jira] [Commented] (CB-13283) Fetching of download counts fails on plugins.cordova.io

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167207#comment-16167207 ] 

ASF GitHub Bot commented on CB-13283:
-------------------------------------

GitHub user devgeeks opened a pull request:

    https://github.com/apache/cordova-docs/pull/731

    [CB-13283] Fetching of download counts fails on plugins.cordova.io

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    Docs
    
    ### What does this PR do?
    
    Just before fetching the download counts from npmjs, this filters plugins based on name, removing scoped packages. This allows the bulk search to go ahead for the remaining packages.
    
    ### What testing has been done on this change?
    
    Manual testing
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/devgeeks/cordova-docs CB-13283

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/731.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #731
    
----
commit a544802addf70b07c7c38dd4e1078ae149370f3f
Author: tommy-carlos williams <to...@devgeeks.org>
Date:   2017-09-15T01:22:08Z

    [CB-13283] Fetching of download counts fails on plugins.cordova.io
    
    Filtered plugins based on name, removing scoped packages. This allows
    the bulk search to go ahead for the remaining packages.

----


> Fetching of download counts fails on plugins.cordova.io
> -------------------------------------------------------
>
>                 Key: CB-13283
>                 URL: https://issues.apache.org/jira/browse/CB-13283
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-docs
>         Environment: All
>            Reporter: Tommy-Carlos Williams
>
> The batched fetching of download counts for returned plugins fails for any requests that contain scoped packages thus blocking the "sort by downloads" from ever appearing and spewing GET errors into the console.
> This is due to npmjs not supporting scoped packages in bulk lookups:
> {code:javascript}
> {"error":"scoped packages are not currently supported in bulk lookups"}
> {code}
> I propose we filter out scoped packages from the bulk lookups. At least then we will get download counts for the packages that are supported in bulk lookups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org