You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "xxubai (via GitHub)" <gi...@apache.org> on 2025/07/08 09:45:28 UTC

[PR] [AMORO-3660] Refactor InternalContainers to Containers and update related references [amoro]

xxubai opened a new pull request, #3661:
URL: https://github.com/apache/amoro/pull/3661

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   Close #3660.
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3660] Refactor InternalContainers to Containers and update related references [amoro]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #3661:
URL: https://github.com/apache/amoro/pull/3661#issuecomment-3083015245

   Thanks for the contribution. Seems we need to rebase on master to fix the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3660] Refactor InternalContainers to Containers and update related references [amoro]

Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 commented on code in PR #3661:
URL: https://github.com/apache/amoro/pull/3661#discussion_r2281259096


##########
amoro-ams/src/test/java/org/apache/amoro/server/AmsEnvironment.java:
##########
@@ -310,7 +311,8 @@ public void stopOptimizer() {
         .listOptimizers()
         .forEach(
             resource -> {
-              InternalContainers.get(resource.getContainerName()).releaseResource(resource);
+              ((AbstractOptimizerContainer) Containers.get(resource.getContainerName()))

Review Comment:
   I think this explicit conversion is a little unsafe. If we assure the Container got from the map always return AbstractOptimizerContainer, then we may need to modify Containers.get() return type. Otherwise I think a if instanceOf is suitable for this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3660] Refactor InternalContainers to Containers and update related references [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3661:
URL: https://github.com/apache/amoro/pull/3661#issuecomment-3195021694

   @majin1102 Can you help to review this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3660] Refactor InternalContainers to Containers and update related references [amoro]

Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai merged PR #3661:
URL: https://github.com/apache/amoro/pull/3661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org