[GitHub] [openwhisk-composer] rabbah commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy
URL: https://github.com/apache/openwhisk-composer/pull/70#discussion_r393769599
 
 

 ##########
 File path: bin/deploy.js
 ##########
 @@ -73,7 +73,8 @@ try {
   for (let annotation of [...(argv.annotation || [])]) {
     const index = annotation.indexOf('=')
     if (index < 0) throw Error('Annotation syntax must be "KEY=VALUE"')
-    composition.annotations.push({ key: annotation.substring(0, index), value: annotation.substring(index + 1) })
+    const value = annotation.substring(index + 1);
 
 Review comment:
   ```suggestion
       const value = annotation.substring(index + 1).toLowerCase();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services