You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by jg...@apache.org on 2013/05/21 13:44:39 UTC

svn commit: r1484767 - in /ant/core/trunk: ./ manual/Types/ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/attribute/ src/main/org/apache/tools/ant/taskdefs/

Author: jglick
Date: Tue May 21 11:44:39 2013
New Revision: 1484767

URL: http://svn.apache.org/r1484767
Log:
#43362 follow-ups: missing/incorrect @since; minor doc improvements and corrections.

Modified:
    ant/core/trunk/WHATSNEW
    ant/core/trunk/manual/Types/namespace.html
    ant/core/trunk/src/main/org/apache/tools/ant/DefaultDefinitions.java
    ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java
    ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/AttributeNamespace.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/BaseIfAttribute.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/EnableAttribute.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfBlankAttribute.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfSetAttribute.java
    ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfTrueAttribute.java
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/AttributeNamespaceDef.java

Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Tue May 21 11:44:39 2013
@@ -51,8 +51,8 @@ Other changes:
 
  * simplifying Execute.getEnvironmentVariables since we are only running on Java 1.5 or higher now
 
- * Add conditional attributes
-   Bugzilla report 43362
+ * Added conditional attributes.
+   Bugzilla Report 43362
 
  * Recommending to upgrade jsch to 0.1.50, particularly if you are using Java 1.7.
    jsch is the library behind the sshexec and scp Ant tasks.

Modified: ant/core/trunk/manual/Types/namespace.html
URL: http://svn.apache.org/viewvc/ant/core/trunk/manual/Types/namespace.html?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/manual/Types/namespace.html (original)
+++ ant/core/trunk/manual/Types/namespace.html Tue May 21 11:44:39 2013
@@ -152,8 +152,8 @@
       </li>
     </ul>
     <p>
-      In Ant 1.9.1 two attribute namespaces ant:if and ant:unless are added in order to allow to insert elements
-      conditionally
+      In Ant 1.9.1 two attribute namespaces <code>ant:if</code> and <code>ant:unless</code> were added
+      to allow you to insert elements conditionally.
     </p>
     <p>
       Other attributes are simply ignored.

Modified: ant/core/trunk/src/main/org/apache/tools/ant/DefaultDefinitions.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DefaultDefinitions.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/DefaultDefinitions.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/DefaultDefinitions.java Tue May 21 11:44:39 2013
@@ -20,6 +20,7 @@ package org.apache.tools.ant;
 
 /**
  * Default definitions.
+ * @since Ant 1.9.1
  */
 public final class DefaultDefinitions {
     private static final String IF_NAMESPACE = "ant:if";
@@ -37,7 +38,7 @@ public final class DefaultDefinitions {
     }
 
     /**
-     * Register the defintions.
+     * Register the definitions.
      */
     public void execute() {
         attributeNamespaceDef(IF_NAMESPACE);

Modified: ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/MagicNames.java Tue May 21 11:44:39 2013
@@ -276,9 +276,11 @@ public final class MagicNames {
      * @since Ant 1.9.0
      */
     public static final String ANT_VM_LAUNCHER_REF_ID = "ant.vmLauncher";
-    /** Name of the namespace "type" (note: cannot be used as an element)
-     *  @since  Ant 1.9.1
-     * */
+    /**
+     * Name of the namespace "type".
+     * (Note: cannot be used as an element.)
+     * @since Ant 1.9.1
+     */
     public static final String ATTRIBUTE_NAMESPACE = "attribute namespace";
 }
 

Modified: ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/RuntimeConfigurable.java Tue May 21 11:44:39 2013
@@ -132,6 +132,7 @@ public class RuntimeConfigurable impleme
      * @param owner the UE that owns this RC.
      * @return true if enabled, false if any of the ant attribures return
      *              false.
+     * @since 1.9.1
      */
     public boolean isEnabled(UnknownElement owner) {
         if (!namespacedAttribute) {

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/AttributeNamespace.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/AttributeNamespace.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/AttributeNamespace.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/AttributeNamespace.java Tue May 21 11:44:39 2013
@@ -19,8 +19,10 @@
 package org.apache.tools.ant.attribute;
 
 /**
- * This class is used to indicate that the xml namespace (uri)
+ * This class is used to indicate that the XML namespace (URI)
  * can be used to look for namespace attributes.
+ * @see org.apache.tools.ant.taskdefs.AttributeNamespaceDef
+ * @since Ant 1.9.1
  */
 public final class AttributeNamespace {
 }

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/BaseIfAttribute.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/BaseIfAttribute.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/BaseIfAttribute.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/BaseIfAttribute.java Tue May 21 11:44:39 2013
@@ -31,6 +31,7 @@ import org.apache.tools.ant.UnknownEleme
  * An abstract class for if/unless attributes.
  * This contains a boolean flag to specify whether this is an
  * if or unless attribute.
+ * @since Ant 1.9.1
  */
 public abstract class BaseIfAttribute
     extends ProjectComponent implements EnableAttribute {

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/EnableAttribute.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/EnableAttribute.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/EnableAttribute.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/EnableAttribute.java Tue May 21 11:44:39 2013
@@ -21,7 +21,8 @@ package org.apache.tools.ant.attribute;
 import org.apache.tools.ant.UnknownElement;
 
 /**
- * This interface is used by ant attributes.
+ * This interface is used by Ant attributes.
+ * @since Ant 1.9.1
  */
 public interface EnableAttribute {
     /**

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfBlankAttribute.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfBlankAttribute.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfBlankAttribute.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfBlankAttribute.java Tue May 21 11:44:39 2013
@@ -22,6 +22,7 @@ import org.apache.tools.ant.UnknownEleme
 
 /**
  * Check if an attribute is blank or not.
+ * @since Ant 1.9.1
  */
 public class IfBlankAttribute extends BaseIfAttribute {
     /** The unless version */

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfSetAttribute.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfSetAttribute.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfSetAttribute.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfSetAttribute.java Tue May 21 11:44:39 2013
@@ -22,6 +22,7 @@ import org.apache.tools.ant.UnknownEleme
 
 /**
  * Check if an attribute value as a property is set or not
+ * @since Ant 1.9.1
  */
 public class IfSetAttribute extends BaseIfAttribute {
     /** The unless version */

Modified: ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfTrueAttribute.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfTrueAttribute.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfTrueAttribute.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/attribute/IfTrueAttribute.java Tue May 21 11:44:39 2013
@@ -23,6 +23,7 @@ import org.apache.tools.ant.UnknownEleme
 
 /**
  * Check if an attribute value is true or not.
+ * @since Ant 1.9.1
  */
 public class IfTrueAttribute extends BaseIfAttribute {
     /** The unless version */

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/AttributeNamespaceDef.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/AttributeNamespaceDef.java?rev=1484767&r1=1484766&r2=1484767&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/AttributeNamespaceDef.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/AttributeNamespaceDef.java Tue May 21 11:44:39 2013
@@ -24,16 +24,16 @@ import org.apache.tools.ant.AntTypeDefin
 import org.apache.tools.ant.attribute.AttributeNamespace;
 
 /**
- * Defintion to allow the uri to be considered for
- * ant attributes.
+ * Definition to allow the URI to be considered for
+ * Ant attributes.
  *
- * @since Ant 1.8.0
+ * @since Ant 1.9.1
  */
 public final class AttributeNamespaceDef  extends AntlibDefinition {
 
     /**
      * Run the definition.
-     * This registers the xml namespace (uri) as a namepace for
+     * This registers the XML namespace (URI) as a namepace for
      * attributes.
      */
     public void execute() {