You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/24 10:04:17 UTC
[GitHub] [skywalking-python] wenbindu opened a new pull request, #255: change the generator of traceId to the 3-parts
wenbindu opened a new pull request, #255:
URL: https://github.com/apache/skywalking-python/pull/255
update the traceid format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #255: change the generator of traceId to the 3-parts
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #255:
URL: https://github.com/apache/skywalking-python/pull/255#issuecomment-1326227083
Why are you proposing this? This seems never to be discussed and have conclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng closed pull request #255: change the generator of traceId to the 3-parts
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #255: change the generator of traceId to the 3-parts
URL: https://github.com/apache/skywalking-python/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #255: change the generator of traceId to the 3-parts
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #255:
URL: https://github.com/apache/skywalking-python/pull/255#issuecomment-1326608357
The code doesn't seem reasonable and it's a core change. Please elaborate the purpose/benefit of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wenbindu commented on pull request #255: change the generator of traceId to the 3-parts
Posted by GitBox <gi...@apache.org>.
wenbindu commented on PR #255:
URL: https://github.com/apache/skywalking-python/pull/255#issuecomment-1333061638
> Why are you proposing this? This seems never to be discussed and have a conclusion.
The trace id generator of java sdk is consist of three parts, like: `3bcc7c8bbf7e4697b006e44eb6a43ec6.904.16698607453910135`, can we make an impletation of the python's generator under the same specification? Maybe, it's better for users to manage the traceid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #255: change the generator of traceId to the 3-parts
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #255:
URL: https://github.com/apache/skywalking-python/pull/255#issuecomment-1333067151
You simulate Java's trace ID, but actually, this is not the same as Java's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org