You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by lq...@apache.org on 2017/11/07 10:08:50 UTC

qpid-broker-j git commit: NO-JIRA: [Broker-J] Add comment about "silent link stealing" in AMQP 1.0

Repository: qpid-broker-j
Updated Branches:
  refs/heads/master d91e06176 -> 103d76a14


NO-JIRA: [Broker-J] Add comment about "silent link stealing" in AMQP 1.0


Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/103d76a1
Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/103d76a1
Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/103d76a1

Branch: refs/heads/master
Commit: 103d76a146b9d50e9c1f0059e93b293f7399715e
Parents: d91e061
Author: Lorenz Quack <lq...@apache.org>
Authored: Tue Nov 7 10:07:52 2017 +0000
Committer: Lorenz Quack <lq...@apache.org>
Committed: Tue Nov 7 10:08:26 2017 +0000

----------------------------------------------------------------------
 .../apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/103d76a1/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java
----------------------------------------------------------------------
diff --git a/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java b/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java
index 04cb94e..22ae98b 100644
--- a/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java
+++ b/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AbstractLinkEndpoint.java
@@ -465,7 +465,10 @@ public abstract class AbstractLinkEndpoint<S extends BaseSource, T extends BaseT
                 _state = State.DETACHED;
                 break;
             default:
-                // "silent link stealing"
+                // "silent link stealing": If a link is attached on a different connection (i.e., it is "stolen") then
+                //  the spec say we must close the link with a link:stolen error. This only makes sense if the link is
+                //  attached at the time it is stolen. If it is detached we call it "silent link stealing" and simply
+                //  disassociate the link from the session so that the new connection can use it.
                 if (close)
                 {
                     getSession().dissociateEndpoint(this);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org