You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:39:14 UTC
[GitHub] [commons-lang] XenoAmess opened a new pull request #542: Pattern_to_static_
XenoAmess opened a new pull request #542:
URL: https://github.com/apache/commons-lang/pull/542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #542: [LANG-1557] Change a Pattern to a static final field, for not letting it compile each time the function invoked.
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #542:
URL: https://github.com/apache/commons-lang/pull/542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#issuecomment-636677473
[](https://coveralls.io/builds/31440044)
Coverage remained the same at 95.028% when pulling **334e12341bce474cb1c9df110272ee5c5c1455c0 on XenoAmess:Pattern_to_static_** into **9fcd9c86edc05a0bd25f8eb73cf840400e5e6b95 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439746094
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String stripChars) {
return stripEnd(str, stripChars);
}
+ private static final Pattern STRIP_ACCENTS_PATTERN = Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
@garydgregory
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #542: Pattern_to_static_
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#issuecomment-636677473
[](https://coveralls.io/builds/31153584)
Coverage remained the same at 95.041% when pulling **67cd989f5245a931b2282726e436c1f8a52fc7a2 on XenoAmess:Pattern_to_static_** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439745405
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String stripChars) {
return stripEnd(str, stripChars);
}
+ private static final Pattern STRIP_ACCENTS_PATTERN = Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
All constants live at the top of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #542: [LANG-1557] change a Pattern to a static final field, for not letting it compile each time the function invoked.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#issuecomment-636677473
[](https://coveralls.io/builds/31433880)
Coverage decreased (-0.03%) to 95.015% when pulling **53593edc3c57e2afeeabfeec20c7c0ffd0ccec6d on XenoAmess:Pattern_to_static_** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org