You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/05/04 20:44:00 UTC

[jira] [Commented] (SOLR-12312) Replication's IndexFetcher buf size can be initialized smarter to not waste RAM/GC

    [ https://issues.apache.org/jira/browse/SOLR-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464372#comment-16464372 ] 

David Smiley commented on SOLR-12312:
-------------------------------------

Latest patch looks good [~millerjeff0]; I like how you identified the re-use of an existing constant for this that the writer is using.  I'll probably reword a comment since I can be obsessive about trivialities.  I'll commit "soon".

> Replication's IndexFetcher buf size can be initialized smarter to not waste RAM/GC
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-12312
>                 URL: https://issues.apache.org/jira/browse/SOLR-12312
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: replication (java)
>            Reporter: David Smiley
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> IndexFetcher's constructor knows the size of the file it's going to transfer.  As-such, it ought to initialize the "buf" field to no larger than this size.  This has been shown to waste Java heap/GC in  an environment with lots of cores of small indexes and thus small files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org