[GitHub] [airflow] dstandish commented on a change in pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #19324:
URL: https://github.com/apache/airflow/pull/19324#discussion_r749731036



##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -253,3 +253,10 @@ def _get_secret(self, path_prefix, secret_id: str) -> Optional[str]:
                 secret_id,
             )
             return None
+        except self.client.exceptions.AccessDeniedException as e:
+            self.log.debug(
+                "An error occurred (AccessDeniedException) when calling the "
+                "get_secret_value operation: %s",
+                str(e),
+            )

Review comment:
       @john-jac not sure  if you saw this comment?  would you mind either implementing the suggestion or stating why not?  i suspect   it was auto-dismissed after a rebase or something.
   
   thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org