You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:45:36 UTC

[GitHub] [flink] JingGe edited a comment on pull request #19060: [FLINK-26532][metrics][test] using the numRecordsSend counter to get the correct metric

JingGe edited a comment on pull request #19060:
URL: https://github.com/apache/flink/pull/19060#issuecomment-1066524534


   > I do not fully understand the fix. AFAIK the `InternalSinkWriterMetricGroup` delegates everything to the parent metric group so when updating something in the `SinkWriterMetricGroup` it should be immediately available also in the parent group.
   
   It is true. But just because the metric is initialized via the parent, does not means it can be accessed by the parent metric group. if you know any other way to do it except adding extra `@VisibleForTesting` method into `AbstractMetricGroup` which will break its current design, please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org