You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lw-lin <gi...@git.apache.org> on 2016/03/11 03:25:43 UTC
[GitHub] spark pull request: Display rate limit on streaming web ui part 3
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/11643
Display rate limit on streaming web ui part 3
## What changes were proposed in this pull request?
This PR makes Streaming web UI display rate-limit lines in the statistics graph.
Design doc: https://issues.apache.org/jira/secure/attachment/12792513/Spark-13618_Design_Doc_v1.pdf
Part 3 (this PR):
- makes changes in `StreamingJobProgressListener` and related places, so that the aggregated `numRecordsLimit` information for every batch can be calculated;
- makes changes in `StreamingPage` and related places, so two or more lines can be drawn on a single statistics graph.
Part 1: [PR #11470](https://github.com/apache/spark/pull/11470)
Part 2: [PR #11633](https://github.com/apache/spark/pull/11633)
## Screenshots
### without back pressure
### with back pressure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark display-rate-limit-on-streaming-web-ui-part-3-
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11643
----
commit 720f2d432cd65c5a3ff82dce08f640a110658e7e
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T12:53:53Z
Collect rate limit numbers on executor side
commit e408e4f5be19c479ce92bdc70360d5fbee7044dd
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T13:29:00Z
Add InputDStream.underRateLimit field
commit e04ec30be52d06d27d5265c247090bcd34f36246
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T13:29:50Z
Merge commit '720f2d432cd65c5a3ff82dce08f640a110658e7e' into rate-5-3
commit b77df2e1a1c90ba518b25ca00a46559f398977b8
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T14:50:21Z
Aggregate rate limit numbers on driver side, and display rate limit line on UI
commit 0cbab6093b060f05688916efe44ba58d24a664e3
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T12:53:53Z
Collect rate limit numbers on executor side
commit 6d0e0f353f98ae18b87afbf20d53d56252db474c
Author: Liwei Lin <pr...@gmail.com>
Date: 2016-03-11T02:11:58Z
Merge commit 'e408e4f5be19c479ce92bdc70360d5fbee7044dd' into rate-0311-bak-03
commit bfae2896e4fbed152cff9637c471b9073f80c1c2
Author: Liwei Lin <pr...@gmail.com>
Date: 2016-03-11T02:17:34Z
Aggregate rate limit numbers on driver side, display rate limit line on UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Display rate limit on streaming web ui part 3
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11643#issuecomment-195149369
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin closed the pull request at:
https://github.com/apache/spark/pull/11643
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Display rate limit on streaming web ui part 3
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11643#issuecomment-195148951
All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully it can help reviewers review this more faster.
This part 3 builds on top of part 1 and 2, so the actual diff should be smaller.
@tdas @zsxwing would you mind taking a look when you have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11643#issuecomment-203804471
This PR has many conflicts to resolve, so I'm closing this for now and will open later, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org