You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by kops <gi...@git.apache.org> on 2015/03/01 16:45:47 UTC
[GitHub] cxf pull request: CXF-6268 Make cxf-codegen-plugin toolchains awar...
GitHub user kops opened a pull request:
https://github.com/apache/cxf/pull/55
CXF-6268 Make cxf-codegen-plugin toolchains aware during maven build
Support toolchains configuration during java code generation.
When _fork_ parameter is enabled,
1. use provided javaExecutable path if available
2. use toolchains configuration if available
3. use default `${java.home}/bin/java`
I added a maven-invoker-plugin to run a simple test using toolchains.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kops/cxf 2.6.x-toolchains
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 16f270e86b40355649aff59b9893e1fd9eb62373
Author: kops <je...@dudie.fr>
Date: 2015-02-25T01:16:54Z
CXF-6268 Add toolchains support to codegen-plugin
Default behavior is modified and the javaExecutable path is resolved in the
following order:
1. a 'javaExecutable' property explicitely set is used as is ;
2. if the the toolchain manager provides a 'jdk' then it is used ;
3. fallback to default behavior: ${java.home}/bin/java.
commit e3322c7f25d8c296e3acc8cd85020eba26106632
Author: kops <je...@dudie.fr>
Date: 2015-03-01T15:26:27Z
CXF-6268 Add integration test
commit 79b42fee70ddc13346606cbab874ac8e5d6dc5da
Author: kops <je...@dudie.fr>
Date: 2015-02-25T01:18:37Z
fix unused import
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6268 Make cxf-codegen-plugin toolchains awar...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/55#issuecomment-76784695
This patch needs to be redone based on master. 2.6.x is unsupported. All patches flow from master -> 3.0.x -> 2.7.x and thus needs to apply cleanly against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6268 Make cxf-codegen-plugin toolchains awar...
Posted by kops <gi...@git.apache.org>.
Github user kops commented on the pull request:
https://github.com/apache/cxf/pull/55#issuecomment-76787194
I will review this patch and submit a new pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: CXF-6268 Make cxf-codegen-plugin toolchains awar...
Posted by kops <gi...@git.apache.org>.
Github user kops closed the pull request at:
https://github.com/apache/cxf/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---