[GitHub] [iceberg] rdblue commented on a change in pull request #3188: Add common view format spec

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3188:
URL: https://github.com/apache/iceberg/pull/3188#discussion_r805437089



##########
File path: site/docs/spec.md
##########
@@ -357,6 +357,7 @@ A manifest file must store the partition spec and other metadata as properties i
 | _required_ | _required_ | `partition-spec`    | JSON fields representation of the partition spec used to write the manifest  |
 | _optional_ | _required_ | `partition-spec-id` | ID of the partition spec used to write the manifest as a string              |
 | _optional_ | _required_ | `format-version`    | Table format version number of the manifest as a string                      |
+| _optional_ | _optional_ | `object-type`       | Type of object this metadata file is for: "table" or "view". Default is "table". |

Review comment:
       I would state that "if missing, assumed to be "table"` rather than "default is table". Using "default" doesn't quite seem correct to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org