You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/20 09:05:29 UTC
[PR] Bump Maven from 3.6.3 to 3.9.16 [maven-site-plugin]
slachiewicz opened a new pull request, #1313:
URL: https://github.com/apache/maven-site-plugin/pull/1313
Moves the compile-time Maven baseline to 3.9.16, the current 3.9.x release, in line with the rest of the plugins (apache/maven#13085). `<prerequisites>` stays at 3.6.3.
transport-wagon and the resolver api/util that maven-reporting-exec 2.0.1 still pulls at 1.4.1 are pinned to 1.9.27, the resolver that Maven 3.9.16 ships; mixing the two resolver lines on the test classpath fails DefaultRepositorySystem wiring. The pin can go once maven-reporting-exec 2.1.0 is in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Maven from 3.6.3 to 3.9.16 [maven-site-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1313:
URL: https://github.com/apache/maven-site-plugin/pull/1313#issuecomment-5751130637
@slachiewicz Why did you merge although I commented on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Maven from 3.6.3 to 3.9.16 [maven-site-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #1313:
URL: https://github.com/apache/maven-site-plugin/pull/1313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Maven from 3.6.3 to 3.9.16 [maven-site-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #1313:
URL: https://github.com/apache/maven-site-plugin/pull/1313#discussion_r4057655295
##########
src/it/projects/MSITE-609/verify.groovy:
##########
@@ -64,11 +64,16 @@ try
System.err.println( "download.html file is missing or a directory." );
return false;
}
+ // the page interpolates ${currentVersion}, which the filtered POM sets from @mavenVersion@
+ String pomContent = FileUtils.fileRead( new File( basedir, "pom.xml" ), "UTF-8" );
+ int start = pomContent.indexOf( "<currentVersion>" ) + "<currentVersion>".length();
+ String currentVersion = pomContent.substring( start, pomContent.indexOf( "</currentVersion>", start ) );
+ String expected = "Download Maven " + currentVersion;
Review Comment:
Done in #1316.
##########
src/it/projects/site-deploy/verify.groovy:
##########
@@ -64,11 +64,16 @@ try
System.err.println( "download.html file is missing or a directory." );
return false;
}
+ // the page interpolates ${currentVersion}, which the filtered POM sets from @mavenVersion@
+ String pomContent = FileUtils.fileRead( new File( basedir, "pom.xml" ), "UTF-8" );
Review Comment:
Done in #1316.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Maven from 3.6.3 to 3.9.16 [maven-site-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #1313:
URL: https://github.com/apache/maven-site-plugin/pull/1313#discussion_r4056917543
##########
src/it/projects/MSITE-609/verify.groovy:
##########
@@ -64,11 +64,16 @@ try
System.err.println( "download.html file is missing or a directory." );
return false;
}
+ // the page interpolates ${currentVersion}, which the filtered POM sets from @mavenVersion@
+ String pomContent = FileUtils.fileRead( new File( basedir, "pom.xml" ), "UTF-8" );
+ int start = pomContent.indexOf( "<currentVersion>" ) + "<currentVersion>".length();
+ String currentVersion = pomContent.substring( start, pomContent.indexOf( "</currentVersion>", start ) );
+ String expected = "Download Maven " + currentVersion;
Review Comment:
Groovy has a very decent XML slurper, why not use it?
##########
src/it/projects/site-deploy/verify.groovy:
##########
@@ -64,11 +64,16 @@ try
System.err.println( "download.html file is missing or a directory." );
return false;
}
+ // the page interpolates ${currentVersion}, which the filtered POM sets from @mavenVersion@
+ String pomContent = FileUtils.fileRead( new File( basedir, "pom.xml" ), "UTF-8" );
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org