You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/11/27 20:10:47 UTC

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific 

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5239

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
......................................................................

IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

This fix is a prototype for discussion. The changes were partially
automated through:

    replace 'audience="Cloudera"' 'audience="Hidden"' -- $FILENAME

    sed -ri 's/(rev="[^"]*)(CDH-[0-9]+)([^"]*")/\1\3/g' $FILENAME

    sed -i 's/ rev=""//g' $FILENAME

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/topics/impala_alter_table.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
6 files changed, 93 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5239/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Removes some of the Cloudera-specific references that can't be removed
with widely-applicable automation.

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Reviewed-on: http://gerrit.cloudera.org:8080/5239
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
3 files changed, 16 insertions(+), 82 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 2:

(13 comments)

> (12 comments)
 > 
 > Because I'm advocating re-doing the automated portions of this
 > change at a later time, I don't want to promote this patch set
 > as-is. Is it practical to say "abandon" for the code review but
 > still come back and pick out bits and pieces (e.g. the changes in
 > impala_jdbc.xml) to become part of a later code review?

Technically, yes - "Abandon"ed patches remain just as visible and can be resurrected with one click.

However, the usual way to do things is to just address the comments and upload a new "Patch Set", as I have done.

http://gerrit.cloudera.org:8080/#/c/5239/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
> "Cloudera"
Done


PS2, Line 16:     sed -i 's/ rev=""//g' $FILENAME
> Let's leave this step out, for a couple of reasons:
Done


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/impala_html.ditaval
File docs/impala_html.ditaval:

PS2, Line 6: <prop att="audience" val="Hidden" action="exclude"/>
> That's fine. We will need to make the same addition in the Cloudera doc bui
SGTM.

Keep in mind that this gerrit instance, though hosted at cloudera.org, is for Apache Impala, so whatever choices Cloudera makes about their git repo is not really in-scope here.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

PS2, Line 25:       <indexterm audience="Hidden">ALTER TABLE statement</indexterm>
> For the <indexterm> tags, maybe we could change those to audience="HTML" so
I think that's orthogonal to this change. It's usually best if patches address a single item, along with maybe some other trivial ones, not big ones like "Are index terms included".

As such, I'd suggest it go in another commit and we keep this one focused on excising "Cloudera"/"CDH"/"Cloudera Manager".


PS2, Line 220:     <p rev="2.3.0 IMPALA-1568">
> The reason I'm so liberal with release numbers and JIRA numbers with this r
SGTM


PS2, Line 406:     <p>
> Here's a case where perhaps there is a corresponding IMPALA- JIRA number we
Done


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:

PS2, Line 30:       Although in <keyword keyref="impala23_full"/>, the <codeph>SHOW FUNCTIONS</codeph> output for
> Just checking that this was a change introduced by Jim. This is a case wher
Yes, it was.


PS2, Line 443: <dlentry rev="2.3.0" id="casttosmallint" audience="Hidden">
> These castto*() functions might be intended to be permanently for internal 
I think that's an issue for a future patch, since it's a question of docs correctness, not of ASF/Cloudera separation.


PS2, Line 619: <dlentry rev="2.3.0" id="typeof">
> Hmm, this might have a corresponding IMPALA- JIRA number that should go in 
I'd call this future work.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_jdbc.xml
File docs/topics/impala_jdbc.xml:

PS2, Line 82:         In Impala 2.0 and later, you must use the Hive 0.13 JDBC driver.  If you are
            :         already using JDBC applications with an earlier Impala release, you must update
            :         your JDBC driver, because the Hive 0.12 driver that was formerly the only choice
            :         is not compatible with Impala
> Urgh. "Must" seems like too strong a statement. I wonder if the right thing
Removed "must"s.

I'd say Apache Impala's docs should talk about open-source JDBC drivers and vendor's docs should talk about their own JDBC drivers.


PS2, Line 120:           To get the JAR files, install the Hive JDBC driver on each host in the cluster that will run
> It's worth checking if there's a generic Hadoop or Hive URL we could refer 
Couldn't find one; added TODO


PS2, Line 139:   hive-common-X.XX.X.jar
             :   hive-jdbc-X.XX.X.jar
             :   hive-metastore-X.XX.X.jar
             :   hive-servi
> We should confirm that these filenames are accurate if someone goes the gen
I poked around on Google and it appears so.


PS2, Line 161:               <xref href="https://github.com/onefoursix/Cloudera-Impala-JDBC-Example" scope="external" format="html">this
> Ironic that there's a reference to "Cloudera Impala" that perhaps we could 
indeed!


-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#4).

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................

IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

This fix is a prototype for discussion. The changes were partially
automated through:

    replace 'audience="Cloudera"' 'audience="hidden"' -- $FILENAME

    sed -ri 's/(rev="[^"]*)(CDH-[0-9]+)([^"]*")/\1\3/g' $FILENAME

    sed -ri 's/(rev="[^"]*) "/\1"/g' $FILENAME

    sed -ri 's/(rev="[^"]* ) /\1/g' $FILENAME

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/topics/impala_alter_table.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
6 files changed, 93 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5239/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5239/3/docs/impala_html.ditaval
File docs/impala_html.ditaval:

PS3, Line 6: H
> Let's stick with all-lowercase 'hidden' for the condition name. That's the 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
......................................................................

IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

This fix is a prototype for discussion. The changes were partially
automated through:

    replace 'audience="Cloudera"' 'audience="Hidden"' -- $FILENAME

    sed -ri 's/(rev="[^"]*)(CDH-[0-9]+)([^"]*")/\1\3/g' $FILENAME

    sed -i 's/ rev=""//g' $FILENAME

    sed -ri 's/(rev="[^"]*) "/\1"/g' $FILENAME

    sed -ri 's/(rev="[^"]* ) /\1/g' $FILENAME

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/topics/impala_alter_table.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
6 files changed, 93 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5239/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 6:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/11/

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 5:

I have substantially reduced the documentation changes after our out-of-band discussion about automation. These are now only the changes that required human intervention (or seemed likely to be one-offs: automatable but not worth it).

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 2:

For the goal mentioned, it LGTM.  I'll defer to others for tag specific comments.

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#3).

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................

IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

This fix is a prototype for discussion. The changes were partially
automated through:

    replace 'audience="Cloudera"' 'audience="Hidden"' -- $FILENAME

    sed -ri 's/(rev="[^"]*)(CDH-[0-9]+)([^"]*")/\1\3/g' $FILENAME

    sed -ri 's/(rev="[^"]*) "/\1"/g' $FILENAME

    sed -ri 's/(rev="[^"]* ) /\1/g' $FILENAME

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
---
M docs/impala_html.ditaval
M docs/impala_pdf.ditaval
M docs/topics/impala_alter_table.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
6 files changed, 93 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5239/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
......................................................................


Patch Set 2:

(12 comments)

Because I'm advocating re-doing the automated portions of this change at a later time, I don't want to promote this patch set as-is. Is it practical to say "abandon" for the code review but still come back and pick out bits and pieces (e.g. the changes in impala_jdbc.xml) to become part of a later code review?

http://gerrit.cloudera.org:8080/#/c/5239/2//COMMIT_MSG
Commit Message:

PS2, Line 16:     sed -i 's/ rev=""//g' $FILENAME
Let's leave this step out, for a couple of reasons:
- There's no harm to have rev="" with an empty attribute value.
- There are some cases where rev="CDH-xyz" could also be annotated with the IMPALA- number, so I think it would be useful to leave behind the empty attribute as a reminder that this was a change due to bug fix or feature addition.
- Sometimes for new feature docs, I add rev="" when I don't have the JIRA number handy and come back and fill it in later.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/impala_html.ditaval
File docs/impala_html.ditaval:

PS2, Line 6: <prop att="audience" val="Hidden" action="exclude"/>
That's fine. We will need to make the same addition in the Cloudera doc build so that the attribute name works transparently in both contexts.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

PS2, Line 25:       <indexterm audience="Hidden">ALTER TABLE statement</indexterm>
For the <indexterm> tags, maybe we could change those to audience="HTML" so they were visible in the PDF. The Cloudera doc team has always been resistant to using index entries but I do have them (just hidden) all through the doc source. We should do a trial and see if enabling them produces a decent-looking index in the PDF.


PS2, Line 220:     <p rev="2.3.0 IMPALA-1568">
The reason I'm so liberal with release numbers and JIRA numbers with this rev= attribute is in hopes of automating an "errata" mechanism in future. I.e. "what changed in such-and-such a release, what changed due to such-and-such an issue". I have an 80% working prototype that I should demo for you guys, to judge should that be something that becomes part of the upstream docs or continue development on it as a Cloudera-only extension.


PS2, Line 406:     <p>
Here's a case where perhaps there is a corresponding IMPALA- JIRA number we should dig up and include in the rev= attribute. That's why I would say to leave an empty rev="" behind, so as not to lose that aspect of the history.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:

PS2, Line 30:       Although in <keyword keyref="impala23_full"/>, the <codeph>SHOW FUNCTIONS</codeph> output for
Just checking that this was a change introduced by Jim. This is a case where we could re-eveluate whether to take out that note, if the situation it refers to is no longer applicable. (I haven't confirmed in this particular case yet.)


PS2, Line 443: <dlentry rev="2.3.0" id="casttosmallint" audience="Hidden">
These castto*() functions might be intended to be permanently for internal Impala use only, in which case we could remove the corresponding info entirely.


PS2, Line 619: <dlentry rev="2.3.0" id="typeof">
Hmm, this might have a corresponding IMPALA- JIRA number that should go in the rev=.


http://gerrit.cloudera.org:8080/#/c/5239/2/docs/topics/impala_jdbc.xml
File docs/topics/impala_jdbc.xml:

PS2, Line 82:         In Impala 2.0 and later, you must use the Hive 0.13 JDBC driver.  If you are
            :         already using JDBC applications with an earlier Impala release, you must update
            :         your JDBC driver, because the Hive 0.12 driver that was formerly the only choice
            :         is not compatible with Impala
Urgh. "Must" seems like too strong a statement. I wonder if the right thing to do here is to say you definitely can use the Hive driver, and maybe there's a vendor-specific driver. Because so many times in the past we've had to warn some people away from the Hive driver for performance reasons, and direct other people to the Hive driver to work around some bug in the Cloudera driver.


PS2, Line 120:           To get the JAR files, install the Hive JDBC driver on each host in the cluster that will run
It's worth checking if there's a generic Hadoop or Hive URL we could refer to here.


PS2, Line 139:   hive-common-X.XX.X.jar
             :   hive-jdbc-X.XX.X.jar
             :   hive-metastore-X.XX.X.jar
             :   hive-servi
We should confirm that these filenames are accurate if someone goes the generic route when installing the Hive driver.


PS2, Line 161:               <xref href="https://github.com/onefoursix/Cloudera-Impala-JDBC-Example" scope="external" format="html">this
Ironic that there's a reference to "Cloudera Impala" that perhaps we could never actually get rid of.


-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#5).

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................

IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Removes some of the Cloudera-specific references that can't be removed
with widely-applicable automation.

Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
---
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_jdbc.xml
M docs/topics/impala_operators.xml
3 files changed, 16 insertions(+), 82 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5239/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 6: Code-Review+2

Carry John's +2 after rebase

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5239/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
"Cloudera"


-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 5: Code-Review+2

I'm trusting that you verified the mods to the Hive JDBC driver filenames; I'm not an expert on that driver.

Because the JDBC stuff involves changes to advice, and because the JDBC page has always been troublesome (e.g. in danger of information going stale), we may revisit that file later (but could be post-graduation) with an SME.

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 3:

Any additional concerns, here?

-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5239/3/docs/impala_html.ditaval
File docs/impala_html.ditaval:

PS3, Line 6: H
Let's stick with all-lowercase 'hidden' for the condition name. That's the convention we've used in cases like 'integrated' and 'standalone', i.e. when the name isn't a proper noun or acronym like PDF / HTML.


-- 
To view, visit http://gerrit.cloudera.org:8080/5239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f63fb309e0617d7fe014231bb0ab0ad67c8474
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes