You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/26 16:58:00 UTC

[jira] [Work logged] (GOBBLIN-707) combine & standardize all gobblin scripts into one master script & restructure configs accordingly

     [ https://issues.apache.org/jira/browse/GOBBLIN-707?focusedWorklogId=319084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319084 ]

ASF GitHub Bot logged work on GOBBLIN-707:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Sep/19 16:57
            Start Date: 26/Sep/19 16:57
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on issue #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#issuecomment-535593899
 
 
   @jhsenjaliya looks like there are conflicts. Can you take a look? Once you resolve the conflicts, I can merge the PR.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 319084)
    Time Spent: 10h  (was: 9h 50m)

> combine & standardize all gobblin scripts into one master script & restructure configs accordingly
> --------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-707
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-707
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jay Sen
>            Priority: Major
>          Time Spent: 10h
>  Remaining Estimate: 0h
>
> gobblin supports multiple modes of executions ( CLI, Standalone, cluster-master, cluster-worker, AWS, YARN, MR ) and various command lines utility to run cli and admin commands. The problem is each cli and execution mode has individual script to manage the service, which brings following problems.
> Having individual script introduces lot of issues
>  # all scripts handles gobblin variables, user parameters differently, and its highly inconsistent among various different gobblin scripts, not to mention different features supported by different scripts.
>  # functionality around start, stop, status checking and handling PID's among lot of other things, varies vastly as per the implementation of the script.
>  # features like GC & JVM params, log4j file selection, classpath calculation, etc... exists in some gobblin scripts but not all, adding to inconsistent user experience.
> # code duplication: all the gobblin scripts share lot of common code to handle params, start, stop services, status checks, pid handling, etc... combining all the scripts into 1 not only makes maintenance easier but also brings clarity and consistency. 
> # Basically, current 13 different scripts adds confusion to new user on how to use Gobblin or how to use it.
> Solution:
> 1. there can be one gobblin.sh script to handle all gobblin commands and deployment options as per following signature. NOTE: This
> {{gobblin.sh  <command> <params>}}
>  {{gobblin.sh  <execution-mode> <start|stop|status>}}
> {{commands values: admin, cli, statestore-check, statestore-clean, historystore-manager, classpath}}
>  {{service values: standalone, cluster-master, cluster-worker, aws, yarn, mr, service}}
> with above change, following becomes valid command.
> {code:java}
> # all under GobblinCli class
> gobblin run listQuickApps  –> gobblin cli run listQuickApps <params>
> gobblin run <quick-app-name> -> gobblin cli run <quick-app-name> <params>
> # class: JobStateToJsonConverter
> statestore-checker.sh <args> -> gobblin cli job-state-to-json <params>
> # class: StateStoreCleaner
> statestore-clean.sh <args> -> the class is depricated so no need to migrate this over.
> # class: DatabaseJobHistoryStoreSchemaManager
> historystore-manager.sh <args> -> gobblin cli job-store-schema-manager <params>
> # class: Cli
> gobblin-admin.sh <args>   -> gobblin cli admin <args>
> # all gobblin deployment modes
> gobblin-cluster-master.sh   -> gobblin service cluster-master start|stop|status
> gobblin-cluster-worker.sh   -> gobblin service cluster-worker start|stop|status
> gobblin-compaction.sh       -> gobblin-compaction.sh  ( kept as it is for now, can be migrated to new script framework)
> gobblin-mapreduce.sh        -> gobblin service mapreduce start|stop|status
> gobblin-service.sh               -> gobblin service service-manager start|stop|status
> gobblin-standalone.sh        -> gobblin service standalone start|stop|status
> gobblin-yarn.sh                   -> gobblin service yarn start|stop|status
> {code}
>  
> 2. Also all configurations for each mode needs to be structured and de-duped accordingly to make it clear on which config will be picked up for which execution mode. This would be well defined in command help instructions.
>  {color:#ff0000}
>  NOTE: this refactoring adds all cli and service commands to gobblin.sh and hence changes the syntax for all commands and services.{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)