You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/10 22:36:27 UTC

[GitHub] [kafka] rondagostino opened a new pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

rondagostino opened a new pull request #10298:
URL: https://github.com/apache/kafka/pull/10298


   The client compatibility system test cannot pass for Raft-based quorums because several APIs have not yet been implemented, and these not-yet-implemented APIs were disabled via https://github.com/apache/kafka/pull/10194/.  The client compatibility system tests now fail since that patch was merged.  This patch disables this system test for Raft-based quorums.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on a change in pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10298:
URL: https://github.com/apache/kafka/pull/10298#discussion_r592112634



##########
File path: tests/kafkatest/tests/client/client_compatibility_features_test.py
##########
@@ -109,7 +109,7 @@ def invoke_compatibility_program(self, features):
           raise
 
     @cluster(num_nodes=7)
-    @matrix(broker_version=[str(DEV_BRANCH)], metadata_quorum=quorum.all_non_upgrade)
+    @parametrize(broker_version=str(DEV_BRANCH))

Review comment:
       How about setting "describe-acls-supported" to `false`? We can still test other features for raft.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10298:
URL: https://github.com/apache/kafka/pull/10298#issuecomment-796245045


   This needs to be cherry-picked to `2.8`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rondagostino commented on pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10298:
URL: https://github.com/apache/kafka/pull/10298#issuecomment-796968115


   Closing in favor of https://github.com/apache/kafka/pull/10292 -- thanks @chia7712!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rondagostino closed pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

Posted by GitBox <gi...@apache.org>.
rondagostino closed pull request #10298:
URL: https://github.com/apache/kafka/pull/10298


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org