[GitHub] [hadoop] mustafaiman commented on a change in pull request #1795: HADOOP-16792: Make S3 client request timeout configurable

[GitBox <gi...@apache.org>]

mustafaiman commented on a change in pull request #1795: HADOOP-16792: Make S3 client request timeout configurable
URL: https://github.com/apache/hadoop/pull/1795#discussion_r368046503
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
 ##########
 @@ -187,6 +187,10 @@ private Constants() {
   public static final String SOCKET_TIMEOUT = "fs.s3a.connection.timeout";
   public static final int DEFAULT_SOCKET_TIMEOUT = 200000;
 
+  // milliseconds until a request is timed-out
+  public static final String REQUEST_TIMEOUT = "fs.s3a.connection.request.timeout";
+  public static final int DEFAULT_REQUEST_TIMEOUT = 0;
 
 Review comment:
   It is 0 by default already. It means, http client will not timeout. This preserves the existing behavior and is a good assumption for guys who does not have any reason to change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org