You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/07 13:07:20 UTC
Re: Review Request 41859: [WIP][MESOS-4265] Launch tasks after
evicting executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 8:07 p.m.)
Review request for mesos and Guangya Liu.
Summary (updated)
-----------------
[WIP][MESOS-4265] Launch tasks after evicting executors.
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 8, 2016, 5:12 p.m., Jian Qiu wrote:
> > src/slave/slave.cpp, line 1449
> > <https://reviews.apache.org/r/41859/diff/2/?file=1184622#file1184622line1449>
> >
> > If an evictable executor is in terminating state because of task finished, it cannot be moved out of evictableExecutors here.
Yes, it's removed in `removeExecutors()`. It's no impact to `getEvictableExecutors` in next cycle.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/#review113440
-----------------------------------------------------------
On Jan. 8, 2016, 2:55 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41859/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 2:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> launch tasks after evicting executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/#review113440
-----------------------------------------------------------
src/slave/slave.cpp (line 1449)
<https://reviews.apache.org/r/41859/#comment174089>
If an evictable executor is in terminating state because of task finished, it cannot be moved out of evictableExecutors here.
- Jian Qiu
On 一月 8, 2016, 6:55 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41859/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 6:55 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> launch tasks after evicting executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated March 11, 2016, 3:10 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
rebase
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs (updated)
-----
include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a
include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144
src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 11:36 a.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Add mesos.proto
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs (updated)
-----
include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 5:23 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
typo
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41859: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 2:55 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
Launch tasks after evicting executors.
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41859: WIP: Launch tasks after evicting executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 8:36 p.m.)
Review request for mesos and Guangya Liu.
Summary (updated)
-----------------
WIP: Launch tasks after evicting executors.
Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265
Repository: mesos
Description
-------
launch tasks after evicting executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41859/diff/
Testing
-------
Thanks,
Klaus Ma