You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "MohamedAbdeen21 (via GitHub)" <gi...@apache.org> on 2025/05/07 19:58:44 UTC
[PR] Postgresql ALTER TABLE operation: REPLICA IDENTITY [datafusion-sqlparser-rs]
MohamedAbdeen21 opened a new pull request, #1844:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1844
Add support for the psql-specific ALTER TABLE operation REPLICA IDENTITY
Docs: https://www.postgresql.org/docs/current/sql-altertable.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Postgresql ALTER TABLE operation: REPLICA IDENTITY [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1844:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1844#discussion_r2082694788
##########
src/ast/ddl.rs:
##########
@@ -39,6 +39,27 @@ use crate::ast::{
use crate::keywords::Keyword;
use crate::tokenizer::Token;
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
Review Comment:
It could be helpful here to add a description comment for the enum with a link to the docs
##########
src/ast/ddl.rs:
##########
@@ -208,6 +229,12 @@ pub enum AlterTableOperation {
old_partitions: Vec<Expr>,
new_partitions: Vec<Expr>,
},
+ /// REPLICA IDENTITY { DEFAULT | USING INDEX index_name | FULL | NOTHING }
+ ///
+ /// Note: this is a PostgreSQL-specific operation.
Review Comment:
Can we add a link to the docs ideally so folks can easily find where the syntax comes from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org