[jira] [Comment Edited] (KNOX-1144) Provider Configuration Reference Relationships Aren't Established For Existing Descriptors at Gateway Startup

["Phil Zampino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287738#comment-16287738 ] 

Phil Zampino edited comment on KNOX-1144 at 12/12/17 7:25 PM:
--------------------------------------------------------------

Attached KNOX-1144.patch

The TopologyService now determines provider configuration reference relationships for any existing simple descriptors at gateway startup time. This should address the issue.

Furthermore, the remote configuration monitor immediately downloads any existing provider configurations (which either do not exist locally, or are different from the local contents), to avoid any inconsistent behavior due to downloading a remote descriptor before its referenced provider config; I've not ever seen this happen yet, but this change should prevent any potential for inconsistent behavior wrt updating descriptors when their referenced provider configs change.

To test this patch:
# Start the gateway
# Add one or more provider configurations to conf/shared-providers/
# Add one or more descriptors, which reference those provider configs, to conf/descriptors
# Stop the gateway
# Modify one or more provider configurations
# Start the gateway
# Verify that topologies for the affected descriptors were regenerated with the new provider configs.
# Stop the gateway
# Start the gateway
# Modify one or more provider configurations
# Verify that topologies for the affected descriptors were regenerated with the new provider configs.



was (Author: pzampino):
Attached KNOX-1144.patch

The TopologyService now determines provider configuration reference relationships for any existing simple descriptors at gateway startup time. This should address the issue.

Furthermore, the remote configuration monitor immediately downloads any existing provider configurations (which either do not exist locally, or are different from the local contents), to avoid any inconsistent behavior due to downloading a remote descriptor before its referenced provider config; I've not ever seen this happen yet, but this change should prevent any potential for inconsistent behavior wrt updating descriptors when their referenced provider configs change.


> Provider Configuration Reference Relationships Aren't Established For Existing Descriptors at Gateway Startup
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: KNOX-1144
>                 URL: https://issues.apache.org/jira/browse/KNOX-1144
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.14.0
>            Reporter: Phil Zampino
>            Assignee: Phil Zampino
>             Fix For: 0.15.0
>
>         Attachments: KNOX-1144.patch
>
>
> Changes to existing provider configurations don't result in updates to the existing descriptors which reference them.
> This is a consequence of changing the startup behavior wrt simple descriptors. Now that existing simple descriptors no longer trigger topology regeneration at startup (unless they've changed since shutdown), the relationships between simple descriptors and the provider configurations they reference are not being established.
> These relationships need to be established when the TopologyService is initialized.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)