You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Michael Wall (JIRA)" <ji...@apache.org> on 2014/01/21 04:23:20 UTC

[jira] [Commented] (ACCUMULO-2100) instamo-archetype could use a little clean up

    [ https://issues.apache.org/jira/browse/ACCUMULO-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877140#comment-13877140 ] 

Michael Wall commented on ACCUMULO-2100:
----------------------------------------

[~elserj] I meant to push this up earlier, but want to start this conversation again.  It is hard for me to think in terms of the archetype.  Thinking in terms of what the archetype generates is much easier.

Take a look at https://github.com/mjwall/ACCUMULO-2100 and let me know your thoughts.  This is what I had in mind for a MiniAccumuloClusterWrapper.  From the wrapper, I would add code to handle inserting data and reusing an existing directory based on options.  Seemed better than trying to change the MiniAccumuloCluster itself until I could work out exactly what I would propose.

I'll look at the changes you made in the branch and see if there is overlap.  

> instamo-archetype could use a little clean up
> ---------------------------------------------
>
>                 Key: ACCUMULO-2100
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2100
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: instamo-archetype
>            Reporter: Michael Wall
>            Assignee: Josh Elser
>            Priority: Minor
>
> Some of the things I noticed
> - mvn test fails, because it took longer than 30 secs to startup the MAC on my linux box.
> - README needs to be updated, usage is incorrect
> - pom.xml doesn't hook exec:exec into any lifecycle so you have to call mvn compile exec:exec -Pwhatever
> - Could abstract out a MiniAccumuloClusterWrapper to handle the temp directory clean up and make the usage across the ShellExample, MapReduceExample and ExampleAccumuloUnitTest consistent.  Would also make it easier to implement ACCUMULO-2097 and ACCUMULO-2098
> BTW, I am running this against the origin/1.5 branch, targeting an archetype that is compatible with Accumulo 1.5.0
> Patch coming for review



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)