You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2010/01/12 22:15:54 UTC
[jira] Created: (SHINDIG-1264) Cleanup javascript for use with
closure-compiler
Cleanup javascript for use with closure-compiler
------------------------------------------------
Key: SHINDIG-1264
URL: https://issues.apache.org/jira/browse/SHINDIG-1264
Project: Shindig
Issue Type: Bug
Components: Javascript
Affects Versions: 1.1-BETA5
Reporter: Paul Lindner
The closure compiler is very picky about jsdoc comments. It found a number of issues.
codereview here:
http://codereview.appspot.com/186110
Changes needed include lowercasing built-in types ({String Boolean, etc} to string, boolean
Remove Map.<> syntax and use Object.<> syntax
remove entities (< etc...)
give functions proper arguments.
etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1264) Cleanup javascript for use with
closure-compiler
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1264.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA6
js fixes checked in
> Cleanup javascript for use with closure-compiler
> ------------------------------------------------
>
> Key: SHINDIG-1264
> URL: https://issues.apache.org/jira/browse/SHINDIG-1264
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 1.1-BETA5
> Reporter: Paul Lindner
> Fix For: 1.1-BETA6
>
>
> The closure compiler is very picky about jsdoc comments. It found a number of issues.
> codereview here:
> http://codereview.appspot.com/186110
> Changes needed include lowercasing built-in types ({String Boolean, etc} to string, boolean
> Remove Map.<> syntax and use Object.<> syntax
> remove entities (< etc...)
> give functions proper arguments.
> etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1264) Cleanup javascript for use with
closure-compiler
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799395#action_12799395 ]
Paul Lindner commented on SHINDIG-1264:
---------------------------------------
remaining warnings:
0 error(s), 0 warning(s), 46.2% typed
target/classes/features/auth-refresh/auth-refresh.js
0 error(s), 0 warning(s), 39.5% typed
target/classes/features/caja/caja.js
target/classes/features/caja/taming.js:48: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
(1, tamings___[tamer])(globalScope);
^
0 error(s), 1 warning(s), 62.2% typed
target/classes/features/caja/taming.js
0 error(s), 1 warning(s), 88.9% typed
target/classes/features/core.auth/auth-init.js
0 error(s), 0 warning(s), 59.0% typed
target/classes/features/core.auth/auth.js
0 error(s), 0 warning(s), 75.6% typed
target/classes/features/core.config/config.js
target/classes/features/core.io/io.js:410: WARNING - Function respondWithPreload: called with 4 argument(s). Function requires at least 3 argument(s) and no more than 3 argument(s).
if (!respondWithPreload(paramData, params, callback, processResponse)) {
^
0 error(s), 15 warning(s), 70.9% typed
target/classes/features/core.io/io.js
0 error(s), 0 warning(s), 69.2% typed
target/classes/features/core.io/taming.js
0 error(s), 0 warning(s), 78.0% typed
target/classes/features/core.json/json.js
0 error(s), 0 warning(s), 71.4% typed
target/classes/features/core.json/taming.js
target/classes/features/core.legacy/legacy.js:184: WARNING - actual parameter 1 of Document.prototype.getElementById does not match formal parameter
found : (Object|null|string)
required: string
return document.getElementById ? document.getElementById(el) : null;
^
target/classes/features/core.legacy/legacy.js:198: WARNING - inconsistent return type
found : (Array|NodeList)
required: (Array|null)
return document.getElementsByTagName ?
^
0 error(s), 3 warning(s), 66.9% typed
target/classes/features/core.legacy/legacy.js
0 error(s), 0 warning(s), 84.3% typed
target/classes/features/core.log/log.js
0 error(s), 0 warning(s), 57.1% typed
target/classes/features/core.log/taming.js
0 error(s), 2 warning(s), 79.1% typed
target/classes/features/core.prefs/prefs.js
0 error(s), 0 warning(s), 63.8% typed
target/classes/features/core.prefs/taming.js
0 error(s), 0 warning(s), 66.7% typed
target/classes/features/core.util/taming.js
0 error(s), 2 warning(s), 91.6% typed
target/classes/features/core.util/util.js
0 error(s), 2 warning(s), 86.6% typed
target/classes/features/dynamic-height/dynamic-height.js
0 error(s), 0 warning(s), 71.4% typed
target/classes/features/dynamic-height/taming.js
0 error(s), 0 warning(s), 95.7% typed
target/classes/features/dynamic-height.util/dynamic-height-util.js
target/classes/features/flash/flash.js:226: WARNING - Function gadgets.flash.embedCachedFlash: called with 4 argument(s). Function requires at least 0 argument(s) and no more than 0 argument(s).
return gadgets.flash.embedCachedFlash(swfUrl, swfContainer, opt_params.swf_version,
^
0 error(s), 2 warning(s), 85.0% typed
target/classes/features/flash/flash.js
0 error(s), 0 warning(s), 66.2% typed
target/classes/features/flash/taming.js
0 error(s), 0 warning(s), 80.0% typed
target/classes/features/i18n/currencycodemap.js
target/classes/features/i18n/datetimeformat.js:511: WARNING - parameter timeZone does not appear in gadgets.i18n.DateTimeFormat.prototype.formatTimeZoneRFC_'s parameter list
function(count, date) {
^
0 error(s), 2 warning(s), 88.4% typed
target/classes/features/i18n/datetimeformat.js
0 error(s), 14 warning(s), 70.2% typed
target/classes/features/i18n/datetimeformattest.js
0 error(s), 1 warning(s), 90.0% typed
target/classes/features/i18n/datetimeparse.js
0 error(s), 15 warning(s), 71.7% typed
target/classes/features/i18n/datetimeparsetest.js
0 error(s), 7 warning(s), 67.7% typed
target/classes/features/i18n/formatting.js
0 error(s), 5 warning(s), 85.2% typed
target/classes/features/i18n/numberformat.js
0 error(s), 18 warning(s), 47.4% typed
target/classes/features/i18n/numberformattest.js
target/classes/features/minimessage/minimessage.js:41: WARNING - dangerous use of the global this object
this.numMessages_ = 0;
^
target/classes/features/minimessage/minimessage.js:42: WARNING - dangerous use of the global this object
this.moduleId_ = opt_moduleId || 0;
^
target/classes/features/minimessage/minimessage.js:43: WARNING - dangerous use of the global this object
this.container_ = typeof opt_container === 'object' ?
^
target/classes/features/minimessage/minimessage.js:196: WARNING - actual parameter 1 of Node.prototype.appendChild does not match formal parameter
found : (Object|null)
required: (Node|null)
td.appendChild(message);
^
0 error(s), 11 warning(s), 82.2% typed
target/classes/features/minimessage/minimessage.js
0 error(s), 0 warning(s), 66.7% typed
target/classes/features/minimessage/taming.js
0 error(s), 0 warning(s), 98.8% typed
target/classes/features/oauthpopup/oauthpopup.js
0 error(s), 10 warning(s), 43.9% typed
target/classes/features/opensocial-0.6/opensocial6to7.js
0 error(s), 5 warning(s), 47.8% typed
target/classes/features/opensocial-0.7/opensocial7to8.js
0 error(s), 2 warning(s), 50.6% typed
target/classes/features/opensocial-0.8/opensocial8to9.js
0 error(s), 0 warning(s), 64.0% typed
target/classes/features/opensocial-base/fieldtranslations.js
0 error(s), 1 warning(s), 61.5% typed
target/classes/features/opensocial-base/jsonactivity.js
0 error(s), 0 warning(s), 63.4% typed
target/classes/features/opensocial-base/jsonmessage.js
0 error(s), 0 warning(s), 65.0% typed
target/classes/features/opensocial-base/jsonmessagecollection.js
0 error(s), 0 warning(s), 56.7% typed
target/classes/features/opensocial-base/jsonperson.js
target/classes/features/opensocial-data/data.js:256: WARNING - Parse error. missing closing >
* @type {Object.<string, Function(Object)>} A map of custom callbacks for the
target/classes/features/opensocial-data/data.js:344: WARNING - parameter data does not appear in opensocial.data.onAPIResponse's parameter list
opensocial.data.onAPIResponse = function(responseItem, keys, callbacks) {
^
target/classes/features/opensocial-data/data.js:392: WARNING - Parse error. missing opening (
* @param {function} handler Method to call when this tag is invoked.
^
target/classes/features/opensocial-data/data.js:485: WARNING - actual parameter 1 of opensocial.data.RequestDescriptor does not match formal parameter
found : Node
required: (Element|null)
var requestDescriptor = new opensocial.data.RequestDescriptor(child);
^
target/classes/features/opensocial-data/data.js:542: WARNING - parameter fieldStr does not appear in opensocial.data.addFieldsToParams_'s parameter list
opensocial.data.addFieldsToParams_ = function(params, fieldsStr) {
^
0 error(s), 12 warning(s), 60.9% typed
target/classes/features/opensocial-data/data.js
target/classes/features/opensocial-data-context/datacontext.js:85: WARNING - actual parameter 2 of maybeFireListener does not match formal parameter
found : (Array|null|string)
required: string
maybeFireListener(listener, keys);
^
target/classes/features/opensocial-data-context/datacontext.js:92: WARNING - Parse error. type not recognized due to syntax error
* @param {Object.<string, ?>} An map of keys to check.
^
target/classes/features/opensocial-data-context/datacontext.js:95: WARNING - parameter An does not appear in isDataReady's parameter list
var isDataReady = function(keys) {
^
target/classes/features/opensocial-data-context/datacontext.js:151: WARNING - actual parameter 2 of maybeFireListener does not match formal parameter
found : Array
required: string
maybeFireListener(listener, keys);
^
0 error(s), 7 warning(s), 92.7% typed
target/classes/features/opensocial-data-context/datacontext.js
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:31: WARNING - dangerous use of the global this object
this.path_ = path.replace("%host%", document.location.host);
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:35: WARNING - dangerous use of the global this object
this.invalidatePath_ = invalidatePath.replace("%host%",
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:50: WARNING - dangerous use of the global this object
this.environment_ = new opensocial.Environment(configParams.domain,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:53: WARNING - dangerous use of the global this object
this.securityToken_ = shindig.auth.getSecurityToken();
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:60: WARNING - dangerous use of the global this object
this.rpc = rpc;
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:61: WARNING - dangerous use of the global this object
this.processData = opt_processData ||
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:66: WARNING - dangerous use of the global this object
this.processResponse = function(originalDataRequest, rawJson, error, errorMessage) {
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:301: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(peopleRequest.rpc,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:321: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:373: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:387: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc);
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:396: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc);
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:407: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:437: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc);
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:476: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc,
^
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js:492: WARNING - cannot instantiate non-constructor
return new JsonRpcRequestItem(rpc,
^
0 error(s), 20 warning(s), 56.1% typed
target/classes/features/opensocial-jsonrpc/jsonrpccontainer.js
target/classes/features/opensocial-reference/activity.js:374: WARNING - assignment
found : string
required: (Object|null)
return (this.fields_[key] = data);
^
0 error(s), 2 warning(s), 83.1% typed
target/classes/features/opensocial-reference/activity.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/address.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/bodytype.js
0 error(s), 0 warning(s), 77.0% typed
target/classes/features/opensocial-reference/collection.js
target/classes/features/opensocial-reference/container.js:99: WARNING - optional arguments must be at the end
opensocial.Container.prototype.requestSendMessage = function(recipients,
^
target/classes/features/opensocial-reference/container.js:130: WARNING - optional arguments must be at the end
opensocial.Container.prototype.requestShareApp = function(recipients, reason,
^
target/classes/features/opensocial-reference/container.js:351: WARNING - parameter title does not appear in opensocial.Container.prototype.newActivity's parameter list
opensocial.Container.prototype.newActivity = function(opt_params) {
^
target/classes/features/opensocial-reference/container.js:405: WARNING - parameter parameters does not appear in opensocial.Container.prototype.newIdSpec's parameter list
opensocial.Container.prototype.newIdSpec = function(params) {
^
target/classes/features/opensocial-reference/container.js:420: WARNING - parameter parameters does not appear in opensocial.Container.prototype.newNavigationParameters's parameter list
opensocial.Container.prototype.newNavigationParameters = function(params) {
^
0 error(s), 40 warning(s), 68.3% typed
target/classes/features/opensocial-reference/container.js
target/classes/features/opensocial-reference/datarequest.js:288: WARNING - assignment
found : *
required: (Object|null)
params[name] = params[name] || defaultValue;
^
target/classes/features/opensocial-reference/datarequest.js:426: WARNING - actual parameter 1 of opensocial.DataRequest.prototype.asArray does not match formal parameter
found : (Array|null|string)
required: (Object|null)
this.asArray(keys), opt_params);
^
0 error(s), 6 warning(s), 72.1% typed
target/classes/features/opensocial-reference/datarequest.js
target/classes/features/opensocial-reference/dataresponse.js:56: WARNING - optional arguments must be at the end
opensocial.DataResponse = function(responseItems, opt_globalError,
^
0 error(s), 3 warning(s), 84.4% typed
target/classes/features/opensocial-reference/dataresponse.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/email.js
0 error(s), 0 warning(s), 69.7% typed
target/classes/features/opensocial-reference/enum.js
0 error(s), 1 warning(s), 87.8% typed
target/classes/features/opensocial-reference/environment.js
0 error(s), 1 warning(s), 73.6% typed
target/classes/features/opensocial-reference/idspec.js
0 error(s), 1 warning(s), 85.2% typed
target/classes/features/opensocial-reference/mediaitem.js
target/classes/features/opensocial-reference/message.js:51: WARNING - parameter body does not appear in opensocial.Message's parameter list
opensocial.Message = function(body_or_params, opt_params) {
^
target/classes/features/opensocial-reference/message.js:56: WARNING - assignment
found : string
required: (Object|null)
this.fields_[opensocial.Message.Field.BODY] = body_or_params;
^
0 error(s), 4 warning(s), 78.1% typed
target/classes/features/opensocial-reference/message.js
target/classes/features/opensocial-reference/messagecollection.js:45: WARNING - parameter body does not appear in opensocial.MessageCollection's parameter list
opensocial.MessageCollection = function(opt_params) {
^
target/classes/features/opensocial-reference/messagecollection.js:127: WARNING - assignment
found : string
required: (Object|null)
return this.fields_[key] = data;
^
0 error(s), 4 warning(s), 81.4% typed
target/classes/features/opensocial-reference/messagecollection.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/name.js
0 error(s), 1 warning(s), 72.9% typed
target/classes/features/opensocial-reference/navigationparameters.js
target/classes/features/opensocial-reference/opensocial.js:426: WARNING - parameter parameters does not appear in opensocial.newIdSpec's parameter list
opensocial.newIdSpec = function(params) {
^
target/classes/features/opensocial-reference/opensocial.js:446: WARNING - parameter parameters does not appear in opensocial.newNavigationParameters's parameter list
opensocial.newNavigationParameters = function(params) {
^
target/classes/features/opensocial-reference/opensocial.js:467: WARNING - cannot instantiate non-constructor
this.prototype = new tempCtor();
^
0 error(s), 42 warning(s), 64.4% typed
target/classes/features/opensocial-reference/opensocial.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/organization.js
target/classes/features/opensocial-reference/person.js:499: WARNING - Function opensocial.Person.prototype.getField: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
return this.getField(opensocial.Person.Field.ID);
^
target/classes/features/opensocial-reference/person.js:517: WARNING - Function opensocial.Person.prototype.getField: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
var name = this.getField(opensocial.Person.Field.NAME);
^
target/classes/features/opensocial-reference/person.js:537: WARNING - Function opensocial.Person.prototype.getField: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
return this.getField(opensocial.Person.Field.NICKNAME);
^
0 error(s), 4 warning(s), 72.2% typed
target/classes/features/opensocial-reference/person.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/phone.js
0 error(s), 1 warning(s), 77.8% typed
target/classes/features/opensocial-reference/responseitem.js
0 error(s), 0 warning(s), 62.0% typed
target/classes/features/opensocial-reference/taming.js
0 error(s), 1 warning(s), 67.7% typed
target/classes/features/opensocial-reference/url.js
target/classes/features/opensocial-templates/base.js:308: WARNING - Redeclared variable: data
var data = context.jsexec(selectInner, node);
^
0 error(s), 5 warning(s), 52.9% typed
target/classes/features/opensocial-templates/base.js
target/classes/features/opensocial-templates/compiler.js:153: WARNING - parameter expr does not appear in os.replaceTopLevelVars_'s parameter list
os.replaceTopLevelVars_ = function(text) {
^
target/classes/features/opensocial-templates/compiler.js:790: WARNING - inconsistent return type
found : boolean
required: string
return os.canStartIdentifier(ch) || (ch >= '0' && ch <= '9') ||
^
target/classes/features/opensocial-templates/compiler.js:802: WARNING - inconsistent return type
found : (boolean|string)
required: string
return os.canBeInIdentifier(ch) || ch == '(' || ch == ')' ||
^
0 error(s), 7 warning(s), 64.0% typed
target/classes/features/opensocial-templates/compiler.js
target/classes/features/opensocial-templates/container.js:105: WARNING - Function setTimeout: called with 2 argument(s). Function requires at least 3 argument(s) and no more than 3 argument(s).
setTimeout(arguments.callee, 0);
^
target/classes/features/opensocial-templates/container.js:142: WARNING - Function setTimeout: called with 2 argument(s). Function requires at least 3 argument(s) and no more than 3 argument(s).
setTimeout(callback, 0);
^
target/classes/features/opensocial-templates/container.js:410: WARNING - Function os.Container.processInlineTemplates: called with 2 argument(s). Function requires at least 0 argument(s) and no more than 1 argument(s).
os.Container.processInlineTemplates(opt_data, opt_doc);
^
0 error(s), 4 warning(s), 60.5% typed
target/classes/features/opensocial-templates/container.js
target/classes/features/opensocial-templates/jsTemplate/jsevalcontext.js:311: WARNING - actual parameter 2 of JsEvalContext.prototype.jsexec does not match formal parameter
found : (Element|null|undefined)
required: (Element|null)
return this.jsexec(exprFunction, opt_template);
^
0 error(s), 1 warning(s), 88.8% typed
target/classes/features/opensocial-templates/jsTemplate/jsevalcontext.js
target/classes/features/opensocial-templates/jsTemplate/jstemplate.js:937: WARNING - Redeclared variable: section
var section = domGetElementById(doc, name);
^
0 error(s), 8 warning(s), 71.8% typed
target/classes/features/opensocial-templates/jsTemplate/jstemplate.js
target/classes/features/opensocial-templates/jsTemplate/util.js:137: WARNING - inconsistent return type
found : *
required: (Array|null)
return Function.prototype.call.apply(Array.prototype.slice, arguments);
^
target/classes/features/opensocial-templates/jsTemplate/util.js:177: WARNING - actual parameter 1 of arraySlice does not match formal parameter
found : (Arguments|null)
required: (Array|null)
var args = arraySlice(arguments, 2);
^
target/classes/features/opensocial-templates/jsTemplate/util.js:426: WARNING - actual parameter 1 of domRemoveChild does not match formal parameter
found : (Node|null)
required: (Element|null)
return domRemoveChild(node.parentNode, node);
^
0 error(s), 3 warning(s), 95.9% typed
target/classes/features/opensocial-templates/jsTemplate/util.js
0 error(s), 0 warning(s), 58.8% typed
target/classes/features/opensocial-templates/loader.js
0 error(s), 0 warning(s), 58.3% typed
target/classes/features/opensocial-templates/namespaces.js
target/classes/features/opensocial-templates/os.js:171: WARNING - inconsistent return type
found : undefined
required: (Object|null)
return und;
^
target/classes/features/opensocial-templates/os.js:201: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
if (opensocial) {
^
target/classes/features/opensocial-templates/os.js:203: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
if (opensocial.Person) {
^
0 error(s), 3 warning(s), 54.3% typed
target/classes/features/opensocial-templates/os.js
target/classes/features/opensocial-templates/template.js:140: WARNING - Function os.createContext: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
opt_context = os.createContext(opt_data);
^
target/classes/features/opensocial-templates/template.js:151: WARNING - Function os.createContext: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
opt_context = os.createContext(opt_data);
^
0 error(s), 2 warning(s), 59.4% typed
target/classes/features/opensocial-templates/template.js
0 error(s), 0 warning(s), 96.2% typed
target/classes/features/opensocial-templates/util.js
0 error(s), 0 warning(s), 76.6% typed
target/classes/features/osapi/batch.js
0 error(s), 6 warning(s), 64.7% typed
target/classes/features/osapi/gadgetsrpctransport.js
0 error(s), 0 warning(s), 63.4% typed
target/classes/features/osapi/jsonrpctransport.js
0 error(s), 0 warning(s), 52.7% typed
target/classes/features/osapi/osapi.js
0 error(s), 0 warning(s), 43.8% typed
target/classes/features/osapi/peoplehelpers.js
0 error(s), 0 warning(s), 44.2% typed
target/classes/features/osapi/taming.js
0 error(s), 3 warning(s), 54.2% typed
target/classes/features/pubsub/pubsub-router.js
target/classes/features/pubsub/pubsub.js:53: WARNING - Parse error. missing opening (
* @param {function} callback Callback function that receives messages.
^
0 error(s), 5 warning(s), 78.8% typed
target/classes/features/pubsub/pubsub.js
0 error(s), 0 warning(s), 69.2% typed
target/classes/features/pubsub/taming.js
0 error(s), 7 warning(s), 72.2% typed
target/classes/features/rpc/fe.transport.js
target/classes/features/rpc/ifpc.transport.js:96: WARNING - dangerous use of the global this object
iframe.onload = function() { this.recyclable = true; };
^
0 error(s), 5 warning(s), 75.6% typed
target/classes/features/rpc/ifpc.transport.js
0 error(s), 6 warning(s), 79.1% typed
target/classes/features/rpc/nix.transport.js
target/classes/features/rpc/rmr.transport.js:88: WARNING - actual parameter 1 of processRmrData does not match formal parameter
found : (string|undefined)
required: string
processRmrData(opt_frameId);
^
0 error(s), 16 warning(s), 71.7% typed
target/classes/features/rpc/rmr.transport.js
target/classes/features/rpc/rpc.js:473: WARNING - actual parameter 3 of setRelayUrl does not match formal parameter
found : boolean
required: (string|undefined)
setRelayUrl('..', parentRelayUrl, useLegacy);
^
0 error(s), 23 warning(s), 76.7% typed
target/classes/features/rpc/rpc.js
0 error(s), 9 warning(s), 63.9% typed
target/classes/features/rpc/wpm.transport.js
target/classes/features/setprefs/setprefs.js:32: WARNING - parameter val does not appear in gadgets.Prefs.prototype.set's parameter list
gadgets.Prefs.prototype.set = function(key, value) {
^
0 error(s), 3 warning(s), 75.0% typed
target/classes/features/setprefs/setprefs.js
0 error(s), 1 warning(s), 79.3% typed
target/classes/features/settitle/settitle.js
0 error(s), 0 warning(s), 75.0% typed
target/classes/features/settitle/taming.js
0 error(s), 3 warning(s), 71.7% typed
target/classes/features/skins/skins.js
0 error(s), 0 warning(s), 75.0% typed
target/classes/features/skins/taming.js
target/classes/features/tabs/tabs.js:78: WARNING - Parse error. missing closing )
* @return {function({string}} The callback function of the tab.
^
target/classes/features/tabs/tabs.js:112: WARNING - dangerous use of the global this object
this.moduleId_ = opt_moduleId || 0;
^
target/classes/features/tabs/tabs.js:113: WARNING - dangerous use of the global this object
this.domIdFilter_ = new RegExp('^[A-Za-z]([0-9a-zA-Z_:.-]+)?$');
^
target/classes/features/tabs/tabs.js:114: WARNING - dangerous use of the global this object
this.selectedTab_ = null;
^
target/classes/features/tabs/tabs.js:115: WARNING - dangerous use of the global this object
this.tabs_ = [];
^
target/classes/features/tabs/tabs.js:116: WARNING - dangerous use of the global this object
this.tabsAdded_ = 0;
^
target/classes/features/tabs/tabs.js:117: WARNING - dangerous use of the global this object
this.defaultTabName_ = opt_defaultTab || '';
^
target/classes/features/tabs/tabs.js:118: WARNING - dangerous use of the global this object
this.leftNavContainer_ = null;
^
target/classes/features/tabs/tabs.js:119: WARNING - dangerous use of the global this object
this.rightNavContainer_ = null;
^
target/classes/features/tabs/tabs.js:120: WARNING - dangerous use of the global this object
this.navTable_ = null;
^
target/classes/features/tabs/tabs.js:121: WARNING - dangerous use of the global this object
this.tabsContainer_ = null;
^
target/classes/features/tabs/tabs.js:122: WARNING - dangerous use of the global this object
this.rtl_ = document.body.dir === 'rtl';
^
target/classes/features/tabs/tabs.js:123: WARNING - dangerous use of the global this object
this.mainContainer_ = this.createMainContainer_(opt_container);
^
target/classes/features/tabs/tabs.js:124: WARNING - dangerous use of the global this object
this.tabTable_ = this.createTabTable_();
^
target/classes/features/tabs/tabs.js:540: WARNING - Function setTimeout: called with 2 argument(s). Function requires at least 3 argument(s) and no more than 3 argument(s).
setTimeout(timeoutFn, 10);
^
0 error(s), 34 warning(s), 73.0% typed
target/classes/features/tabs/tabs.js
0 error(s), 0 warning(s), 62.5% typed
target/classes/features/tabs/taming.js
0 error(s), 0 warning(s), 61.8% typed
target/classes/features/views/taming.js
target/classes/features/views/views.js:181: WARNING - Function getVar: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
if (map(j, getVar(match[1]), match[1])) {
^
target/classes/features/views/views.js:242: WARNING - Function getVar: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s).
var value = getVar(match[1]);
^
0 error(s), 12 warning(s), 65.9% typed
target/classes/features/views/views.js
0 error(s), 0 warning(s), 81.2% typed
target/classes/features/xmlutil/xmlutil.js
> Cleanup javascript for use with closure-compiler
> ------------------------------------------------
>
> Key: SHINDIG-1264
> URL: https://issues.apache.org/jira/browse/SHINDIG-1264
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 1.1-BETA5
> Reporter: Paul Lindner
>
> The closure compiler is very picky about jsdoc comments. It found a number of issues.
> codereview here:
> http://codereview.appspot.com/186110
> Changes needed include lowercasing built-in types ({String Boolean, etc} to string, boolean
> Remove Map.<> syntax and use Object.<> syntax
> remove entities (< etc...)
> give functions proper arguments.
> etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.