You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by mashengchen <gi...@git.apache.org> on 2018/04/04 02:27:18 UTC
[GitHub] trafodion pull request #1505: TRAFODION-3019 pstmt.setByte cannot support st...
GitHub user mashengchen opened a pull request:
https://github.com/apache/trafodion/pull/1505
TRAFODION-3019 pstmt.setByte cannot support string.getbyte well
fill in blank when give value to a char() type.
support Chinese value, when column type is UCS2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mashengchen/trafodion JIRA3019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1505
----
commit 7914d91ec16e631adacf5d866675bb6f7326e7fa
Author: aven <sh...@...>
Date: 2018-04-04T02:22:22Z
TRAFODION-3019 pstmt.setByte cannot support string.getbyte well
----
---
[GitHub] trafodion pull request #1505: TRAFODION-3019 pstmt.setByte cannot support st...
Posted by mashengchen <gi...@git.apache.org>.
Github user mashengchen commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1505#discussion_r179932150
--- Diff: core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXDesc.java ---
@@ -424,7 +424,7 @@ void checkValidNumericConversion(Locale locale) throws SQLException
public static final int SQLCHARSETCODE_GB2312 = 17;
public static final String SQLCHARSETSTRING_UNKNOWN = "UNKNOWN";
- public static final String SQLCHARSETSTRING_ISO88591 = "ISO88591";
+ public static final String SQLCHARSETSTRING_ISO88591 = "ISO-8859-1";
--- End diff --
this is only used in java code for character encoding, see SQLMXPreparedStatement.java:1981 which changed this time.
this variable is never used or passed to SQL engine
---
[GitHub] trafodion pull request #1505: TRAFODION-3019 pstmt.setByte cannot support st...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1505#discussion_r179297836
--- Diff: core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXDesc.java ---
@@ -424,7 +424,7 @@ void checkValidNumericConversion(Locale locale) throws SQLException
public static final int SQLCHARSETCODE_GB2312 = 17;
public static final String SQLCHARSETSTRING_UNKNOWN = "UNKNOWN";
- public static final String SQLCHARSETSTRING_ISO88591 = "ISO88591";
+ public static final String SQLCHARSETSTRING_ISO88591 = "ISO-8859-1";
--- End diff --
I am curious why this has been changed. In the SQL engine itself, we use "ISO88591". Will this cause a problem?
---
[GitHub] trafodion pull request #1505: TRAFODION-3019 pstmt.setByte cannot support st...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1505
---