[GitHub] [pinot] xiangfu0 commented on a change in pull request #8174: Adding scala profile for kafka 2.x build and remove root pom scala dependencies

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #8174:
URL: https://github.com/apache/pinot/pull/8174#discussion_r803308023



##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/pom.xml
##########
@@ -100,4 +98,28 @@
       <artifactId>jopt-simple</artifactId>
     </dependency>
   </dependencies>
+
+
+  <profiles>
+    <profile>
+      <id>scala-2.12</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       The reason is I've got a lot request for scala 2.12 support, hence make this as default and allow upgrade to 2.13.
   
   Basically this is similar to kafka 0.9 and 2.x, users can build a connector based on the scala version from their enviroment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org